Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Stick @types/node to 9.6.7 to avoid problems with 10.0.0 #315

Merged
merged 1 commit into from
May 2, 2018
Merged

Stick @types/node to 9.6.7 to avoid problems with 10.0.0 #315

merged 1 commit into from
May 2, 2018

Conversation

DorianGrey
Copy link
Collaborator

@DorianGrey DorianGrey commented Apr 27, 2018 •
edited
Loading

@types/node 10.0.0 broke the travis build (again), since it causes collisions with typescripts own definitions. Stick with 9.6.7 for now will hopefully fix this...

Refers to: DefinitelyTyped/DefinitelyTyped#25342
Restriction should be retained until this issue gets resolved.

@DorianGrey
Copy link
Collaborator Author

The kitchensink test is failing (again) due to a missing babel-loader - still investigating what causes this problem...

@DorianGrey
Copy link
Collaborator Author

I'll push this through for now, the CI problem seems unrelated, and I'm still investigating it.

@DorianGrey DorianGrey merged commit 10b727f into wmonk:master May 2, 2018
sebald pushed a commit to sebald/create-react-app-typescript that referenced this pull request May 8, 2018
Merge branch 'master' into allow-moduleNameMapper-override
25d06bb 
* master:
  Stick @types/node to 9.6.7 to avoid problems with 10.0.0 (wmonk#315)
  Fix travis build (wmonk#302)
  v2.15.1
  Update README For 2.15.1
  fix(modules): remove duplicate mjs from jest config
@wmonk
Copy link
Owner

wmonk commented May 10, 2018

@DorianGrey I think we should revert this before the next release - what do you think?

@DorianGrey
Copy link
Collaborator Author

DorianGrey commented May 11, 2018 •
edited
Loading

@wmonk - yes, I'll revert it (#321), Just added this since it wasn't predictable how a long a fix in the typings will take. Luckily, this didn't took long.

DorianGrey added a commit that referenced this pull request May 11, 2018
@DorianGrey
Revert "Stick @types/node to 9.6.7 to avoid problems with 10.0.0 (#315)"
f8b28e6 
This reverts commit 10b727f.
@DorianGrey DorianGrey mentioned this pull request May 11, 2018
Merged
This was referenced Jul 16, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2021
Open
@jimmyrperezpierola jimmyrperezpierola mentioned this pull request Mar 31, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DorianGrey @wmonk