Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setuptools in pyproject.toml to >=51.0.0? #553

Closed
FollowTheProcess opened this issue Dec 28, 2021 · 5 comments
Closed

Bump setuptools in pyproject.toml to >=51.0.0? #553

FollowTheProcess opened this issue Dec 28, 2021 · 5 comments
Labels

Comments

@FollowTheProcess
Copy link
Collaborator

Describe the bug

While doing some digging in the setuptools documentation I came across this section: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#options which (if I'm reading it correctly) suggests that in order to use the options.entry_points key (as we do in our setup.cfg here), you must use setuptools >= 51.0.0.

Currently we specify setuptools >= 42 in pyproject.toml here

If this is correct and I'm not reading it wrong, does this mean we could get a broken install if someone uses setuptools < 51?

Given that no one (to my knowledge) has raised an issue about this I think it's safe to assume no one has fell foul of this, but it seems like something we should fix?

@DiddiLeija
Copy link
Collaborator

I agree. I don't know if we'll break something in the process, though.

@henryiii
Copy link
Collaborator

What the... Pretty sure this is not new in 51. It's been around as long as I can remember.

@henryiii
Copy link
Collaborator

Thinking they meant to put "41" not "51", perhaps.

@layday
Copy link
Contributor

layday commented Jan 9, 2022

Pretty sure that existed even before 41. In fact it appears to have been there in the very first version of setup.cfg: pypa/setuptools#862.

@cjolowicz
Copy link
Collaborator

cjolowicz commented Jan 9, 2022

Closing as per #553 (comment), thanks @layday and @henryiii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants