-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump setuptools in pyproject.toml to >=51.0.0? #553
Comments
I agree. I don't know if we'll break something in the process, though. |
What the... Pretty sure this is not new in 51. It's been around as long as I can remember. |
Thinking they meant to put "41" not "51", perhaps. |
Pretty sure that existed even before 41. In fact it appears to have been there in the very first version of |
Closing as per #553 (comment), thanks @layday and @henryiii |
Describe the bug
While doing some digging in the setuptools documentation I came across this section: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#options which (if I'm reading it correctly) suggests that in order to use the
options.entry_points
key (as we do in oursetup.cfg
here), you must use setuptools >= 51.0.0.Currently we specify setuptools >= 42 in
pyproject.toml
hereIf this is correct and I'm not reading it wrong, does this mean we could get a broken install if someone uses setuptools < 51?
Given that no one (to my knowledge) has raised an issue about this I think it's safe to assume no one has fell foul of this, but it seems like something we should fix?
The text was updated successfully, but these errors were encountered: