Fix regression in check for stale environments #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `sys.real_prefix` was set by virtualenv < 20.0. - `sys.base_prefix` is used by virtualenv >= 20.0 and python -m venv (PEP 405)
When comparing the resolved interpreter to the interpreter in an existing virtualenv, we need to use sys.base_prefix (or sys.real_prefix) for both. The resolved interpreter is located in the virtualenv, so its sys.prefix would point into the virtualenv instead of the base installation. This bug results in virtualenvs never being reused.
Environments created by virtualenv < 20.0.0 do not have pyvenv.cfg files.
theacodes
approved these changes
May 23, 2021
|
Thanks for fixing this (and adding tests to cover the regression!) |
This was referenced Jun 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424