Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LICENSE from the manifest file #505

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Remove LICENSE from the manifest file #505

merged 1 commit into from
Nov 19, 2021

Conversation

DiddiLeija
Copy link
Collaborator

Closes #504. The removed inclusion was redundant, since we use setuptools>=42.

@DiddiLeija
Remove LICENSE from the manifest file
26aa606 
It is redundant, since we use setuptools>=42.
@DiddiLeija DiddiLeija mentioned this pull request Nov 18, 2021
Closed
cjolowicz
cjolowicz approved these changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

❯ rm -rf dist
❯ pyproject-build
❯ tar ztf dist/nox-2021.10.1.tar.gz | grep LICENSE
nox-2021.10.1/LICENSE
❯ unzip -l dist/nox-2021.10.1-py3-none-any.whl | grep LICENSE
    11357  11-19-2021 04:32   nox-2021.10.1.dist-info/LICENSE

@cjolowicz cjolowicz merged commit 6155ee7 into wntrblm:main Nov 19, 2021
@DiddiLeija DiddiLeija deleted the manifest-cleanup branch November 19, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjolowicz cjolowicz cjolowicz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant license inclusion on MANIFEST.in
2 participants
@DiddiLeija @cjolowicz