-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to our noxfile #506
Conversation
* Add Python 3.10 to our "conda_test" session, since GHA already supports Conda. * Add "docs/conf.py" to the files were session "lint" will run, to be the same than the "blacken" step.
Hmm... this step made and some others. Do I have to fix them? Or should I remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
Adding the Sphinx config to the linter checks is a good thing IMO. I'd just apply the few proposed fixes so we can get the file into our check suite.
Make flake8 feel happy with this.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes:
Add Python 3.10 to our
conda_test
session, since GHA already supports Conda (see Add Python 3.10 for conda #501).Add
docs/conf.py
to the files where sessionlint
will run, to be the same than theblacken
step (see Improve the Sphinx config file #499).