Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use uv #805

Merged
merged 2 commits into from
Apr 2, 2024
Merged

ci: use uv #805

merged 2 commits into from
Apr 2, 2024

Conversation

henryiii
Copy link
Collaborator

Use uv for most (but not all) the jobs in CI.

@henryiii henryiii force-pushed the henryiii/ci/uv branch 3 times, most recently from b7486f9 to 9cc2be7 Compare March 29, 2024 06:35
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any particular reason to keep the lint job on pip?

@henryiii
Copy link
Collaborator Author

henryiii commented Apr 2, 2024

uv doesn't support targeting Python 3.7 officially, and an warning will be produced in the future it seems: astral-sh/uv#2757, so probably should disable uv entirely for the 3.7 jobs.

@henryiii
Copy link
Collaborator Author

henryiii commented Apr 2, 2024

For the lint job, pre-commit will never support uv, so I went ahead and left it alone (also to have some non-uv jobs, 3.7 will be removed at some point).

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit 956f10c into wntrblm:main Apr 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants