fix(types): loosen wrapper type definitions

fix apollographql#426
wodCZ · Aug 1, 2021 · 1b6a249 · 1b6a249
1 parent 15d8b40
commit 1b6a249
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 21 deletions.
diff --git a/src/storageWrappers/AsyncStorageWrapper.ts b/src/storageWrappers/AsyncStorageWrapper.ts
@@ -12,23 +12,26 @@ import { PersistentStorage } from '../types';
  * });
  *
  */
-export class AsyncStorageWrapper implements PersistentStorage<string> {
+export class AsyncStorageWrapper implements PersistentStorage<any> {
   // Actual type definition: https://github.com/react-native-async-storage/async-storage/blob/master/types/index.d.ts
   private storage;
 
   constructor(storage: any) {
     this.storage = storage;
   }
 
-  getItem(key: string): string | Promise<string | null> | null {
+  getItem(key: string): any | Promise<any> | null {
     return this.storage.getItem(key);
   }
 
   removeItem(key: string): void | Promise<void> {
     return this.storage.removeItem(key);
   }
 
-  setItem(key: string, value: string): void | Promise<void> {
-    return this.storage.setItem(key, value);
+  setItem(key: string, value: any): void | Promise<void> {
+    return this.storage.setItem(
+      key,
+      typeof value === 'string' ? value : value.toString(),
+    );
   }
 }
diff --git a/src/storageWrappers/IonicStorageWrapper.ts b/src/storageWrappers/IonicStorageWrapper.ts
@@ -1,22 +1,25 @@
 import { PersistentStorage } from '../types';
 
-export class IonicStorageWrapper implements PersistentStorage<string> {
+export class IonicStorageWrapper implements PersistentStorage<any> {
   // Actual type definition: https://github.com/ionic-team/ionic-storage/blob/main/src/storage.ts#L102
   private storage;
 
   constructor(storage: any) {
     this.storage = storage;
   }
 
-  getItem(key: string): string | Promise<string | null> | null {
+  getItem(key: string): any | Promise<any> | null {
     return this.storage.get(key);
   }
 
   removeItem(key: string): void | Promise<void> {
     return this.storage.remove(key);
   }
 
-  setItem(key: string, value: string): void | Promise<void> {
-    return this.storage.set(key, value);
+  setItem(key: string, value: any): void | Promise<void> {
+    return this.storage.set(
+      key,
+      typeof value === 'string' ? value : value.toString(),
+    );
   }
 }
diff --git a/src/storageWrappers/LocalForageWrapper.ts b/src/storageWrappers/LocalForageWrapper.ts
@@ -16,7 +16,7 @@ export class LocalForageWrapper implements PersistentStorage<string | object> {
     return this.storage.removeItem(key);
   }
 
-  setItem(key: string, value: string): void | Promise<void> {
+  setItem(key: string, value: string | object): void | Promise<void> {
     return new Promise((resolve, reject) => {
       this.storage
         .setItem(key, value)

diff --git a/src/storageWrappers/LocalStorageWrapper.ts b/src/storageWrappers/LocalStorageWrapper.ts
@@ -1,22 +1,25 @@
 import { PersistentStorage } from '../types';
 
-export class LocalStorageWrapper implements PersistentStorage<string> {
+export class LocalStorageWrapper implements PersistentStorage<any> {
   // Actual type definition: https://github.com/microsoft/TypeScript/blob/master/lib/lib.dom.d.ts#L15286
   private storage;
 
   constructor(storage: any) {
     this.storage = storage;
   }
 
-  getItem(key: string): string | Promise<string | null> | null {
+  getItem(key: string): any | Promise<any> | null {
     return this.storage.getItem(key);
   }
 
   removeItem(key: string): void | Promise<void> {
     return this.storage.removeItem(key);
   }
 
-  setItem(key: string, value: string): void | Promise<void> {
-    return this.storage.setItem(key, value);
+  setItem(key: string, value: any): void | Promise<void> {
+    return this.storage.setItem(
+      key,
+      typeof value === 'string' ? value : value.toString(),
+    );
   }
 }
diff --git a/src/storageWrappers/MMKVStorageWrapper.ts b/src/storageWrappers/MMKVStorageWrapper.ts
@@ -11,15 +11,15 @@ import { PersistentStorage } from '../types';
  * });
  *
  */
-export class MMKVStorageWrapper implements PersistentStorage<string> {
+export class MMKVStorageWrapper implements PersistentStorage<any> {
   // Actual type definition: https://github.com/ammarahm-ed/react-native-mmkv-storage/blob/master/index.d.ts#L27
   private storage;
 
   constructor(storage: any) {
     this.storage = storage;
   }
 
-  getItem(key: string): string | Promise<string | null> | null {
+  getItem(key: string): any | Promise<any> | null {
     return this.storage.getItem(key);
   }
 
@@ -32,10 +32,10 @@ export class MMKVStorageWrapper implements PersistentStorage<string> {
     });
   }
 
-  setItem(key: string, value: string): void | Promise<void> {
+  setItem(key: string, value: any): void | Promise<void> {
     return new Promise((resolve, reject) => {
       this.storage
-        .setItem(key, value)
+        .setItem(key, typeof value === 'string' ? value : value.toString())
         .then(() => resolve())
         .catch(() => reject());
     });

diff --git a/src/storageWrappers/SessionStorageWrapper.ts b/src/storageWrappers/SessionStorageWrapper.ts
@@ -1,22 +1,25 @@
 import { PersistentStorage } from '../types';
 
-export class SessionStorageWrapper implements PersistentStorage<string> {
+export class SessionStorageWrapper implements PersistentStorage<any> {
   // Actual type definition: https://github.com/microsoft/TypeScript/blob/master/lib/lib.dom.d.ts#L15286
   private storage;
 
   constructor(storage: any) {
     this.storage = storage;
   }
 
-  getItem(key: string): string | Promise<string | null> | null {
+  getItem(key: string): any | Promise<any> | null {
     return this.storage.getItem(key);
   }
 
   removeItem(key: string): void | Promise<void> {
     return this.storage.removeItem(key);
   }
 
-  setItem(key: string, value: string): void | Promise<void> {
-    return this.storage.setItem(key, value);
+  setItem(key: string, value: any): void | Promise<void> {
+    return this.storage.setItem(
+      key,
+      typeof value === 'string' ? value : value.toString(),
+    );
   }
 }