Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code improvements #40

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Code improvements #40

merged 2 commits into from
Dec 29, 2022

Conversation

ShawnCZek
Copy link
Contributor

I have unified the style of PHPDoc and used "new" PHP features instead of the previous approaches.

I would recommend setting up something like StyleCI. PSR-2 itself is not enough to keep the code style the same everywhere.

@wohali wohali merged commit 757c8d7 into wohali:master Dec 29, 2022
@ShawnCZek ShawnCZek deleted the code-cleanup branch December 29, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShawnCZek @wohali