Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Fix wrapper.unmount not calling useEffect cleanup #22

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

Iskander508
Copy link
Contributor

fix for issue with unmount not running useEffect cleanup: #12

@vdwijngaert
Copy link

Would be helpful if this pull request was merged :)

@MikeMcMahon
Copy link

we are using this library as well and it would be very useful

@gisaklement
Copy link

Hi @wojtekmaj
I found your adapter today 🥳 and it seems like the only things that's blocking our pipeline is this PR 🙂
Any chance this pull request can be merged?

Thank you so much helping us out!

@gisaklement
Copy link

Nevermind I just saw your comment here

I'm afraid this will need to wait for an official package to be resolved

Thank you anyway though for this package!!

@wojtekmaj
Copy link
Owner

@gisaklement I started discussing this change in a PR that adds official React 17 adapter this package is based on. Let's see how it goes.

@gisaklement
Copy link

@gisaklement I started discussing this change in a PR that adds official React 17 adapter this package is based on. Let's see how it goes.

Thank you so much!! I appreciate it 🙂

@wojtekmaj
Copy link
Owner

Looks like we won't get an official response anytime soon. Screw this then. @Iskander508 Please kindly rebase your branch off current master, or allow edits from maintainers, so I could check if this doesn't break anything, since tests were added recently.

@wojtekmaj wojtekmaj self-requested a review July 14, 2021 21:59
@wojtekmaj wojtekmaj added the bug Something isn't working label Jul 14, 2021
@Iskander508
Copy link
Contributor Author

Looks like we won't get an official response anytime soon. Screw this then. @Iskander508 Please kindly rebase your branch off current master, or allow edits from maintainers, so I could check if this doesn't break anything, since tests were added recently.

Edits should be allowed already

@Iskander508
Copy link
Contributor Author

rebased

@wojtekmaj
Copy link
Owner

Thanks so much.

Interestingly this doesn't seem to affect neither positively nor negatively any unit tests originally added to Enzyme.

Let's go for it.

@wojtekmaj wojtekmaj merged commit 3894167 into wojtekmaj:master Jul 15, 2021
@wojtekmaj wojtekmaj changed the title Fix unmount Fix wrapper.unmount not calling useEffect cleanup Jul 15, 2021
@gisaklement
Copy link

Again, thank you very much 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants