Fix navigation label typings #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I appreciate your input :) |
|
@wojtekmaj are you going to release version that includes correct typings soon? supporting current one needs extra hacks on our side (removing typings from the package on Thanks. |
|
Hey, |
|
2.17.4 is out! |
|
@wojtekmaj thx, updated and it worked out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the TypeScript definitions issue.
Version of
react-calendarwe have: 2.17.2Our tsconfig.json contains
strict: trueandnoImplicitAny: trueWe got a problem while compiling in strict mode saying that String is typed as any. But actually that seem to be wrong syntax (in JS that syntax used for object destructuring). Here is some short explanation i found online
You could compare what was before and after here
seems like it was caused by #107