Implement showDoubleView prop #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankleng
reviewed
Jul 15, 2020
| @@ -441,7 +450,7 @@ export default class Calendar extends Component { | |||
| onClick={mergeFunctions(clickAction, onClickDay)} | |||
| onClickWeekNumber={onClickWeekNumber} | |||
| onMouseLeave={onMouseLeave} | |||
| showFixedNumberOfWeeks={showFixedNumberOfWeeks} | |||
| showFixedNumberOfWeeks={showFixedNumberOfWeeks || showDoubleView} | |||
There was a problem hiding this comment.
@wojtekmaj thanks for the great lib!
why was showFixedNumberOfWeeks forced to true in double view?
mind if I PR to remove this?
There was a problem hiding this comment.
This is because otherwise the UI would look quite bad with different amount of rows on each side.
There was a problem hiding this comment.
@wojtekmaj got it. so it's subjective. ex. priceline.com implements a dual view without locking down # of weeks.
are you open to a PR to remove this?
we can make showFixedNumberOfWeeks default to true when showDoubleView is true. but can be overridden explicitly. so it won't be a breaking change.
felixmosh
pushed a commit
to felixmosh/react-calendar
that referenced
this pull request
Nov 8, 2020
* Implement showDoubleView * Fix tests for Navigation component * Add unit tests for showDoubleView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82