Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add …--weekend class to Weekdays tiles #490

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Add …--weekend class to Weekdays tiles #490

merged 5 commits into from
Feb 4, 2022

Conversation

fffed
Copy link
Contributor

@fffed fffed commented Feb 19, 2021

Add '--weekend' class to weekday so we could style it differently like on a month view for dates.

@fffed
Add '--weekend' class to weekday
c696fe9 
Add  '--weekend' class to `weekday` so we could style it differently like on a month view for dates.
@fffed
Copy link
Contributor Author

fffed commented Feb 19, 2021

Feel free to reject it ))

@wojtekmaj wojtekmaj added the enhancement New feature or request label Feb 22, 2021
@Chaoste
Copy link

Chaoste commented Apr 9, 2021

Code LGTM, would also love to have that.
Right now we're using :nth-child(6+n) which feels hacky 😅

wojtekmaj
wojtekmaj requested changes Jan 19, 2022
View reviewed changes
Copy link
Owner

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat - although needs a bit more work as weekends are differently defined for Arabic and Hebrew calendars :)

src/MonthView/Weekdays.jsx Outdated Show resolved Hide resolved
src/MonthView/Weekdays.jsx Outdated Show resolved Hide resolved
@wojtekmaj wojtekmaj changed the title Add '--weekend' class to weekday Add …--weekend class to Weekdays tiles Jan 19, 2022
@fffed fffed requested a review from wojtekmaj February 4, 2022 10:59
wojtekmaj
wojtekmaj approved these changes Feb 4, 2022
View reviewed changes
Copy link
Owner

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@wojtekmaj wojtekmaj merged commit fbd8bad into wojtekmaj:main Feb 4, 2022
wojtekmaj added a commit that referenced this pull request Feb 4, 2022
@fffed @wojtekmaj
Add …--weekend class to Weekdays tiles (#490)
b0dc446 
Co-authored-by: Wojciech Maj <kontakt@wojtekmaj.pl>
@Krithiga-Balakrishnan Krithiga-Balakrishnan mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmaj wojtekmaj wojtekmaj approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fffed @Chaoste @wojtekmaj