Remove leading zero span #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicke4
commented
Nov 18, 2020
| @@ -21,50 +21,6 @@ describe('DayInput', () => { | |||
| expect(input).toHaveLength(1); | |||
| }); | |||
|
|
|||
| it('renders "0" given showLeadingZeros if day is <10', () => { | |||
There was a problem hiding this comment.
As the span element is removed, I believe these tests are not needed anymore.
|
Hi @vicke4 - thank you for this PR, but unfortunately I won't be able to accept it. The solution you've build has been proposed and considered many times before but is only compatible with Chromium, leading to leading zero issues on non-Chromium browsers. Inputs are going to get a revamp though soon in #272, and perhaps then what you're suggesting will be possible - stay tuned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wojtekmaj,
First of all thanks for all the wonderful libraries you have built. This PR solves a problem I came across when I was working with react-daterange-picker.
I had to customize the style of the calendar for my needs. So, I added some custom styles for the
inputGroup. That clashed with the style you have to manage the leading zeros (For your reference I've attached a GIF below).This PR eliminates the issue. Let me know if I'm wrong somewhere or I have to change something in the PR.