Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Treat pts as pts #1717

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

courtneypattison
Copy link

@courtneypattison courtneypattison commented Feb 11, 2024

Sets the scale to the actual size of PDF :)

Fixes #1219

@wojtekmaj
Copy link
Owner

Oooooo that's just lovely! Thank you for that!

I'll happily release this, but in the next major, as this change might end up being very impactful on people's UIs.

Also, we may need some documentation change? Not sure, will have to look into that.

@courtneypattison
Copy link
Author

You're welcome! I'm sorry, I was rushing and messed up the commit. It should be pixels instead of points since the conversion is from pdf to css pixels. Also, the util from pdfjs isn't accessible so I just copied it out. I think it makes what is going on more explicit anyway. Hopefully it's correct this time!

@wojtekmaj
Copy link
Owner

That looks good to me! My point stands though - I'll be merging this in the next major release. :) Thanks!

@courtneypattison
Copy link
Author

Great, thank you @wojtekmaj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDFs render too small treating pts as px
2 participants