The entry points have side effects #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O, that might be why I had issues with Firefox on 5.0 beta 🤔 Please kindly rebase (broken build you fixed in #501). |
Webpack "mode: production" builds cause pdfjs fall back to the "fake worker" with "sideEffects: false" in "package.json".
robsco-git
force-pushed
the
fix-side-effects
branch
from
19d20e9
to
0ff5de8
Compare
|
Done :) |
wojtekmaj
changed the title
wojtekmaj
changed the title
|
Thank you! |
alexandernanberg
pushed a commit
to alexandernanberg/react-pdf
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack
mode: productionbuilds cause pdfjs fall back to the "fakeworker" with
sideEffects: falsein react-pdf's package.json.I believe the optimisation related to
sideEffects: falseis preventing these lines from executing when using the Webpack entrypoint:react-pdf/src/entry.webpack.js
Lines 14 to 16 in adb00b8
Relevant reading:
https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
https://stackoverflow.com/a/49203452/2410292