Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to disable annotations including canvas appearance-data #968

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ability to disable annotations including canvas appearance-data #968

wants to merge 1 commit into from

Conversation

yuliya-ivaniukovich
Copy link

Closes #963

@wojtekmaj wojtekmaj self-requested a review March 23, 2022 08:03
wojtekmaj
wojtekmaj reviewed Mar 23, 2022
View reviewed changes
Copy link
Owner

@wojtekmaj wojtekmaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work!

Some comments I have:

  1. annotationMode must be documented.
  2. Having more unit tests would be great. I'll gladly help out.
  3. This technically deprecates renderForms in favor of much more powerful annotationMode, so renderForms is to be marked as deprecated (this one can be on me)

@wojtekmaj wojtekmaj added the enhancement New feature or request label Mar 23, 2022
@wojtekmaj wojtekmaj force-pushed the main branch 3 times, most recently from d14ccb7 to 744f655 Compare March 2, 2023 14:22
@wojtekmaj wojtekmaj force-pushed the main branch 7 times, most recently from 2d488c1 to a077571 Compare May 14, 2024 09:32
@wojtekmaj wojtekmaj force-pushed the main branch 5 times, most recently from 1f758cc to ce6db03 Compare June 10, 2024 23:04
@wojtekmaj wojtekmaj force-pushed the main branch 2 times, most recently from 42a8c3c to 0d68fee Compare June 13, 2024 08:22
@wojtekmaj wojtekmaj force-pushed the main branch 4 times, most recently from d0aabb2 to 736f3f3 Compare July 9, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekmaj wojtekmaj wojtekmaj left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to disable annotations (including bboxes in canvas)
2 participants
@yuliya-ivaniukovich @wojtekmaj