-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edge cases where the number 0 is passed to an input #116
base: main
Are you sure you want to change the base?
Conversation
I've just been looking at a project that uses this library and was amazed to see if I added 00 for the minutes or seconds it ends up as "000" This looks like maybe you're touching that area of code, would this pull request fix that? Repro case: just go to the demo and type 00 Chrome v90 & Ubuntu 20.04 |
@stevokk
Yes, it does, if I remember correctly. I'm hoping @wojtekmaj can find time to review this at some point, but if you don't want to wait for that you can always do what I did and fork |
f995585
to
f63abe2
Compare
f9ccaaa
to
1f072d8
Compare
ecb765b
to
bb5c818
Compare
c87e7b0
to
e2b6fa8
Compare
9095827
to
da6a2c4
Compare
8cf994b
to
52e23f9
Compare
99356e8
to
8a43327
Compare
b7c5fbd
to
ae20d89
Compare
fc2f3a2
to
3442fda
Compare
59333a0
to
0e76e71
Compare
a067b23
to
5e58d95
Compare
acd6c81
to
a337cde
Compare
This fixes this issue: wojtekmaj/react-datetime-picker#147
As well as an issue with showing leading zeroes.
Both issues stem from the fact that sometimes the value of the input element is the number 0 rather than the string "0", and since the number 0 is falsey, this value is interpreted as the input being empty when it's not.