fix: double quotes in string not escaped properly #73

close #73
wokwi · Nov 28, 2021 · 47c105c · 47c105c
1 parent 910143b
commit 47c105c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/spectra.spec.ts b/src/spectra.spec.ts
@@ -6,6 +6,10 @@ describe('spectra', () => {
       expect(encodeObject(['foo', 'bar'])).toEqual('(foo bar)');
     });
 
+    it('should escape quotes in strings', () => {
+      expect(encodeObject(['0.96" OLED'])).toEqual('("0.96\\" OLED")');
+    });
+
     it('should ignore null values', () => {
       expect(encodeObject(['foo', null, 'bar'])).toEqual('(foo bar)');
     });

diff --git a/src/spectra.ts b/src/spectra.ts
@@ -10,7 +10,7 @@ export function encodeString(str: string) {
   if (/^[a-z][a-z0-9_]+$/.test(str)) {
     return str;
   }
-  return `"${str.replace(/"/g, '""')}"`;
+  return `"${str.replace(/"/g, '\\"')}"`;
 }
 
 function encodeNumber(value: number) {