Convert through hole pads to via's #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urish
requested changes
Mar 16, 2020
| return; | ||
| } | ||
|
|
||
| const shapes: { [key: string]: string } = { |
There was a problem hiding this comment.
Since shapes is also defined in convertPad(), let's make it a global const instead defining the exact same object in two different places.
| POLYGON: 'custom' | ||
| }; | ||
|
|
||
| if (shape !== 'ELLIPSE') { |
There was a problem hiding this comment.
Can you please add one test case for non-ellipse shape, so the tests will also cover this if statement?
| ['size', kiUnits(holeRadius)], | ||
| ['drill', kiUnits(drill) * 2], | ||
| ['layers', 'F.Cu', 'B.Cu'], | ||
| ['net', nets.indexOf(net)] |
There was a problem hiding this comment.
Instead of using nets.indexOf(), please use getNetId() (you can see an example in convertPad()). This makes sure we add missing nets to the list as we encounter them (this is a fix to issue #29).
| @@ -56,6 +56,20 @@ describe('convertTrack', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('convertPadToVia', () => { | |||
| it('should correctly parse a PAD and convert it to a Via', () => { | |||
There was a problem hiding this comment.
Good job here! You may need to change the expect() bit after you switch to getNetId() (see my comment about that below)
urish
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.