-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hinting and checking, run by black #102
Open
Armenia01
wants to merge
23
commits into
wolberlab:Code_Class_movement
Choose a base branch
from
Armenia01:6-analysis
base: Code_Class_movement
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added type checking and hinting
added type checking and hinting
added type checking and type hinting
added type checking and type hinting
added type checking and type hinting
added type checking and hinting
added type checking and hinting
added type checking and hinting
added type checking and type hinting
added type checking and hinting
added type checking and hinting
adjusted changes to fix some errors
returned to original
talagayev
changed the base branch from
Code_Class_movement_Setup_Simulation
to
Code_Class_movement
October 2, 2024 11:56
adjusted code, removed duplicate mention of frames present from the earlier code
looks good, removed the NV.Widget, since I am not sure if it is the correct object and the type is not that important here what nglview object it is
added the comments back in and adjusted small parts
adjusted small typos
adjusted and added the comments back in
many modifications and removal of code lines, set it back to initial version
adjusted
adjusted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openmmdl_setup code was updated using type hinting and checking, then run by black