Exposed websocket max_message_size through ConnectionOptions #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criminosis
commented
May 20, 2023
Comment on lines
+183
to
+186
| /// The maximum size of a message. `None` means no size limit. The default value is 64 MiB. | ||
| pub(crate) max_message_size: Option<usize>, | ||
| /// The maximum size of a single message frame. `None` means no size limit. The limit is for | ||
| /// frame payload NOT including the frame header. The default value is 16 MiB. |
There was a problem hiding this comment.
Just forwarded the defaults that were implicit from tungstenite to be consistent to today's behavior.
|
@wolf4ood Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @wolf4ood I bumped into what seems to be an implicit default that wasn't exposed by this crate. These functions:
https://github.com/wolf4ood/gremlin-rs/blob/master/gremlin-client/src/connection.rs#L51
https://github.com/wolf4ood/gremlin-rs/blob/master/gremlin-client/src/aio/connection.rs#L133-L136
Appeared to be leveraging
tungstenite's default websocket settings by using the method that didn't specify a websocket config:https://github.com/snapview/tungstenite-rs/blob/371f8230444e209cc37ec481e94d621eddf5f0af/src/tls.rs#L180
https://github.com/sdroege/async-tungstenite/blob/2365647978412f47e681d498f25b8469f4355f11/src/tokio.rs#L267
This
Nonethen becomes the defaults defined bytungstenite: https://github.com/snapview/tungstenite-rs/blob/master/src/protocol/mod.rs#L39-L70I was having I/O issues bumping into these implicit limits. Fwiw they are "supposed" to be configured to the target graph provider's
max_message_size, and JanusGraph at least sets its default to just 65k, obviously way less than the 64MiB implicitly being used fromtungstenite.I tried to mimic prior builders / config patterns, but happy to make any changes.
If accepted & merged mind cutting a new release?