Fix From<tungstenite::Error> for non async_gremlin features #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xD3CODER
force-pushed
the
fix/errors-tungstenite
branch
from
633bdf6
to
751486d
Compare
xD3CODER
force-pushed
the
fix/errors-tungstenite
branch
from
751486d
to
e97518d
Compare
xD3CODER
changed the title
xD3CODER
force-pushed
the
fix/errors-tungstenite
branch
from
e97518d
to
5cb5cd1
Compare
xD3CODER
force-pushed
the
fix/errors-tungstenite
branch
from
5cb5cd1
to
42ae6b7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
the trait From<tungstenite::Error> is not implemented for GremlinErrorwith non async features.I'm not sure this is the right way to solve the problem.