Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CSharp wrapper tests for authenticated sessions #212

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jun 24, 2022

  • Adds CSharp wrapper tests for authenticated sessions.
  • Fixes issue with C# handle unloading.

@dgarske dgarske self-assigned this Jun 24, 2022
@dgarske dgarske requested a review from anhu June 24, 2022 22:33
@dgarske dgarske assigned anhu and unassigned dgarske Jun 24, 2022
Copy link
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!! One little tiny nit. I'm not sure whether the comment or code should be fixed.

Comment on lines 316 to 319
/* algMode must be either CFB or XOR */
if (algMode != TPM2_Alg.NULL &&
algMode != TPM2_Alg.CFB &&
algMode != TPM2_Alg.XOR) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment doesn't allow for NULL but code does.

@anhu anhu self-requested a review June 27, 2022 17:39
Copy link
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Will merge soon!

@anhu anhu merged commit 2c41a93 into wolfSSL:master Jun 27, 2022
@dgarske dgarske deleted the csharp_add2 branch June 27, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants