support memory mapped tpms #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
requested changes
May 30, 2023
this allows to enable debug on sprintf-less systems.
danielinux
previously approved these changes
Jun 1, 2023
|
Good to go, tested on Qemu. Off to @dgarske for final review & configuration naming (see open comment) |
dgarske
previously approved these changes
Jun 1, 2023
jpbland1
previously approved these changes
Jun 28, 2023
dgarske
dismissed stale reviews from jpbland1, danielinux, and themself
via
21638b0
dgarske
previously approved these changes
Jun 28, 2023
jpbland1
previously approved these changes
Jun 28, 2023
jpbland1
reviewed
Jun 28, 2023
wolftpm/tpm2_tis.h
Outdated
| @@ -54,6 +54,11 @@ WOLFTPM_LOCAL int TPM2_TIS_StartupWait(TPM2_CTX* ctx, int timeout); | |||
| WOLFTPM_LOCAL int TPM2_TIS_Write(TPM2_CTX* ctx, word32 addr, const byte* value, word32 len); | |||
| WOLFTPM_LOCAL int TPM2_TIS_Read(TPM2_CTX* ctx, word32 addr, byte* result, word32 len); | |||
|
|
|||
| #ifdef WOLFTPM_MMIO_BUILTIN_CB | |||
There was a problem hiding this comment.
this is in the hal file and now has the wrong flag
hal/tpm_io_mmio.c
Outdated
| #endif | ||
|
|
||
| #ifndef WOLFTPM_ADV_IO | ||
| #error "WOLFTPM_MMIO_BUILTIN_CB requires WOLFTPM_ADV_IO" |
jpbland1
approved these changes
Jun 28, 2023
dgarske
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled with
--enable-mmioorWOLFTPM_MMIO.