Secure Boot (Root of Trust) - Part 2 #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgarske
commented
Aug 10, 2023
dgarske
commented
- Fix for wolfTPM2_EncryptSecret to not loose error code.
- Avoid using heap (malloc/free) for ecc_point.
jpbland1
requested changes
Aug 11, 2023
src/tpm2_wrap.c
Outdated
| @@ -1063,6 +1068,9 @@ static int wolfTPM2_EncryptSecret_ECC(WOLFTPM2_DEV* dev, const WOLFTPM2_KEY* tpm | |||
| XMEMSET(&eccKeyPriv, 0, sizeof(eccKeyPriv)); | |||
| XMEMSET(&pubPoint, 0, sizeof(pubPoint)); | |||
| XMEMSET(&secretPoint, 0, sizeof(secretPoint)); | |||
| XMEMSET(&r, 0, sizeof(r)); | |||
There was a problem hiding this comment.
r is already pointer type, does de-referencing here point XMEMSET to the buffer or a pointer to the buffer?
There was a problem hiding this comment.
Good catch (this was r directly, then I changed to avoid altering code from r. to r->. I think the behavior is the same. Point to start of array vs pointer to first element in array (same). Pushed fix.
jpbland1
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.