Improvements in auth handling to support Policy Password and Policy Auth Value #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
force-pushed
the
policyauth
branch
3 times, most recently
from
c49ef1a
to
ad156f1
Compare
embhorn
reviewed
May 20, 2024
| TPM2_Packet_PlaceU32(packet, tmpSz); | ||
| /* Update the Auth Area total size in the command packet */ | ||
| i = TPM2_Packet_PlaceU32(packet, authTotalSzPos); | ||
|
|
There was a problem hiding this comment.
(void) i; here to prevent unused warnings when DEBUG_WOLFTPM is not defined
There was a problem hiding this comment.
Fixed:
src/tpm2.c:265:5: warning: Value stored to 'i' is never read [deadcode.DeadStores]
i = TPM2_Packet_PlaceU32(packet, authTotalSzPos);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/tpm2_packet.c:394:9: warning: Value stored to 'i' is never read [deadcode.DeadStores]
i = TPM2_Packet_PlaceU32(packet, authTotalSzPos);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
embhorn
reviewed
May 20, 2024
src/tpm2_packet.c
Outdated
| } | ||
| /* based on position difference places calculated size at marked U32 above */ | ||
| TPM2_Packet_PlaceU32(packet, tmpSz); | ||
| i = TPM2_Packet_PlaceU32(packet, authTotalSzPos); |
embhorn
reviewed
May 20, 2024
wolftpm/tpm2_wrap.h
Outdated
| \return BAD_FUNC_ARG: check the provided arguments | ||
|
|
||
| \param dev pointer to a TPM2_DEV struct | ||
| \param sessionHandle the handle of the current policy session, a session is required to use policy PCR |
There was a problem hiding this comment.
Not listed in function declaration below
embhorn
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPM2_PolicyAuthValueandTPM2_PolicyPassword.wolfTPM2_NVReadAuthPolicyandwolfTPM2_NVWriteAuthPolicy.ZD 17739