CRL improvements and update callback #8006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates, add callback for when CRL entry is updated.
dgarske
requested changes
Sep 23, 2024
SparkiDev
requested changes
Sep 25, 2024
SparkiDev
requested changes
Nov 18, 2024
dgarske
requested changes
Nov 18, 2024
dgarske
requested changes
Nov 18, 2024
src/crl.c
Outdated
| } | ||
|
|
||
| #ifdef WOLFSSL_SMALL_STACK | ||
| dcrl = (DecodedCRL*)XMALLOC(sizeof(DecodedCRL), NULL, DYNAMIC_TYPE_TMP_BUFFER); |
There was a problem hiding this comment.
NIT: This line is over 80 characters.
overlong lines added:
src/crl.c:794 dcrl = (DecodedCRL*)XMALLOC(sizeof(DecodedCRL), NULL, DYNAMIC_TYPE_TMP_BUFFER);
wolfssl/ssl.h
Outdated
| sword32 crlNumber; | ||
| } CrlInfo; | ||
|
|
||
| typedef void (*CbUpdateCRL)(CrlInfo* old, CrlInfo* new); |
There was a problem hiding this comment.
You cannot use new as a variable name with g++ compiler...
configure:41488: g++-13 -c -DHAVE_CRL_UPDATE_CB -Werror -g -ggdb -O0 -Wno-pragmas -Wall -Wextra -Wunknown-pragmas --param=ssp-buffer-size=1 -Waddress -Warray-bounds -Wchar-subscripts -Wcomment -Wfloat-equal -Wformat-security -Wformat=2 -Wmaybe-uninitialized -Wmissing-field-initializers -Wmissing-noreturn -Wnormalized=id -Wpointer-arith -Wshadow -Wsign-compare -Wstrict-overflow=1 -Wswitch-enum -Wundef -Wunused -Wunused-result -Wunused-variable -Wwrite-strings -fwrapv -DHAVE_CONFIG_H -I. -I. -DNO_WOLFSSL_CIPHER_SUITE_TEST -DWOLFSSL_OLD_PRIME_CHECK conftest.c >&5
In file included from ./wolfssl/openssl/ssl.h:37,
from ./wolfssl/openssl/aes.h:44,
from conftest.c:70:
./wolfssl/ssl.h:3507:52: error: expected ',' or '...' before 'new'
3507 | typedef void (*CbUpdateCRL)(CrlInfo* old, CrlInfo* new);
| ^~~
configure:41488: $? = 1
configure: failed program was:
src/crl.c
Outdated
| CRL_Entry* prev = NULL; | ||
| #ifdef HAVE_CRL_UPDATE_CB | ||
| CrlInfo old; | ||
| CrlInfo new; |
There was a problem hiding this comment.
Same here with g++:
[quantum-safe-wolfssl-all-g++-latest-debug] [6 of 36] [55be5035a0-dirty]
autogen.sh 55be5035a0-dirty... real 0m10.586s user 0m8.680s sys 0m1.088s
configure... real 0m25.038s user 0m13.907s sys 0m13.286s
build...src/crl.c: In function ‘int AddCRL(WOLFSSL_CRL*, DecodedCRL*, const byte*, int)’:
src/crl.c:599:13: error: expected unqualified-id before ‘new’
599 | CrlInfo new;
| @@ -3953,6 +3969,12 @@ WOLFSSL_API void wolfSSL_CTX_SetPerformTlsRecordProcessingCb(WOLFSSL_CTX* ctx, | |||
| WOLFSSL_API int wolfSSL_CertManagerSetCRL_IOCb(WOLFSSL_CERT_MANAGER* cm, | |||
| CbCrlIO cb); | |||
| #endif | |||
| #ifdef HAVE_CRL_UPDATE_CB | |||
| WOLFSSL_API int wolfSSL_CertManagerGetCRLInfo(WOLFSSL_CERT_MANAGER* cm, CrlInfo* info, | |||
There was a problem hiding this comment.
Optional fix. Note lots of other occurrences in this file, please don't worry about those.
overlong lines added:
wolfssl/ssl.h:3973 WOLFSSL_API int wolfSSL_CertManagerGetCRLInfo(WOLFSSL_CERT_MANAGER* cm, CrlInfo* info,
dgarske
approved these changes
Nov 18, 2024
SparkiDev
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CRL improvements, add parsing for CRL number, do not allow CRL duplicates, add callback for when CRL entry is updated.
Checklist