Correct kyber levels. Was copy and paste error. #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douzzer
requested changes
Oct 16, 2024
There was a problem hiding this comment.
PRB-liboqs.txt_0 isn't getting along with the changes:
Testing configuration:
--with-liboqs --enable-experimental --enable-opensslextra
Testing DEFAULT: --with-liboqs --enable-experimental --enable-opensslextra
Configure RESULT = 0
make[2]: warning: -j3 forced in submake: resetting jobserver mode.
src/ssl.c:21837:66: error: ‘WOLFSSL_P256_KYBER_LEVEL3’ undeclared here (not in a function); did you mean ‘WOLFSSL_P256_KYBER_LEVEL1’?
21837 | {CURVE_NAME("P384_KYBER_LEVEL3"), WOLFSSL_P384_KYBER_LEVEL3, WOLFSSL_P256_KYBER_LEVEL3},
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| WOLFSSL_P256_KYBER_LEVEL1
src/ssl.c:21837:5: error: missing initializer for field ‘curve’ of ‘WOLF_EC_NIST_NAME’ [-Werror=missing-field-initializers]
21837 | {CURVE_NAME("P384_KYBER_LEVEL3"), WOLFSSL_P384_KYBER_LEVEL3, WOLFSSL_P256_KYBER_LEVEL3},
| ^
In file included from src/ssl.c:[36](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/6175/pipeline-console/?start-byte=0&selected-node=1063#log-36):
./wolfssl/internal.h:6398:12: note: ‘curve’ declared here
6398 | word16 curve;
| ^~~~~
src/ssl.c:21838:66: error: ‘WOLFSSL_P256_KYBER_LEVEL5’ undeclared here (not in a function); did you mean ‘WOLFSSL_P256_KYBER_LEVEL1’?
218[38](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/6175/pipeline-console/?start-byte=0&selected-node=1063#log-38) | {CURVE_NAME("P521_KYBER_LEVEL5"), WOLFSSL_P521_KYBER_LEVEL5, WOLFSSL_P256_KYBER_LEVEL5},
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| WOLFSSL_P256_KYBER_LEVEL1
src/ssl.c:21838:5: error: missing initializer for field ‘curve’ of ‘WOLF_EC_NIST_NAME’ [-Werror=missing-field-initializers]
21838 | {CURVE_NAME("P521_KYBER_LEVEL5"), WOLFSSL_P521_KYBER_LEVEL5, WOLFSSL_P256_KYBER_LEVEL5},
| ^
In file included from src/ssl.c:36:
./wolfssl/internal.h:6[39](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/6175/pipeline-console/?start-byte=0&selected-node=1063#log-39)8:12: note: ‘curve’ declared here
6398 | word16 curve;
| ^~~~~
|
retest this please |
douzzer
approved these changes
Oct 16, 2024
kp-max-li
added a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Oct 28, 2024
Moving from v5.7.2-stable We are picking up: https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.4-stable Updated to implement an important bugfix: wolfSSL/wolfssl#8084
kp-thomas-yau
pushed a commit
to expressvpn/wolfssl-rs
that referenced
this pull request
Oct 29, 2024
Moving from v5.7.2-stable We are picking up: https://github.com/wolfSSL/wolfssl/releases/tag/v5.7.4-stable Updated to implement an important bugfix: wolfSSL/wolfssl#8084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.