-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Espressif Managed Component wolfSSL 5.7.4 post-release update #8251
base: master
Are you sure you want to change the base?
Espressif Managed Component wolfSSL 5.7.4 post-release update #8251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
.gitignore
Outdated
# Autogenerated debug trace headers | ||
wolfssl/debug-trace-error-codes.h | ||
wolfssl/debug-untrace-error-codes.h | ||
ctaocrypt/src/src/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you may have introduced CRLF into this file. Please resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During PR creation, there was no preview warning that there would be a merge conflict. There were petty changes needed so I tried to resolve them with the offered "edit in web" feature. That seems to have pulled in ALL of the changes from master in a new commit, which was specifically what I did not want.
I'm not sure how to proceed without adding a new commit to fix the CRLF from Visual Studio. I could close this one and start over? If I squash, all the specific changes will be lost and new changes included. Only my branch would then reflect the actual published code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you may have introduced CRLF into this file. Please resolve.
ok, @dgarske I'm getting better at recovering from git tangle.
I've fixed up this PR to exclude the problematic .gitignore
, and two other petty files with only spell checks that were causing a merge conflict.
See additional PR comments, below.
7cc156d
to
2b9cfac
Compare
The staging site is still giving me a https://components-staging.espressif.com/components/gojimmypi/mywolfssl/versions/5.7.2 I've published a https://components.espressif.com/components/wolfssl/wolfssl/versions/5.7.4-preview1a?language=en I'll be doing some final checks and testing of those examples. Awaiting this PR to be approved before publishing a final |
ugh. At least one of the examples is failing to compile despite numerous successful tests on the staging site. Unable to test again on staging site today, perhaps I missed a change. This is what I see for the production preview:
results in
@dgarske I've reverted to draft, investigating.... |
ok, this does not seem to be a problem with with publish. It's not just a The entire wolfSSL component source is however present in the This command should have populated the entire directory with both the example and the wolfssl component:
I suspect there's a component web site problem, particularly with the "gateway error" on the staging site. I'll reach out to Espressif for help. It may possibly be some other issue. For reference, here's the
found here: I will leave this PR in draft mode until fully resolved. |
Additional information:
And sure enough, from the build log - note last lines:
None of the published wolfSSL cmake ever files remove the wolfSSL component. This is what is in
This did not happen with the staging-components. I believe the prior production work fine. However, this does not seem to be limited to the new preview. The latest |
2b9cfac
to
06c0c09
Compare
The latest force push commit replaces the idf_component_register(SRCS main.c
INCLUDE_DIRS "."
"./include"
PRIV_REQUIRES driver "${MAIN_WOLFSSL_COMPONENT_NAME}") In doing so, additional explicit references were also needed for some examples (e.g. Note that a variable This appears to resolve the undesired I did try actually using other wolfSSL code directly in The observed behavior with the staging Managed Components was different from the release site. Code that worked perfectly on the staging site still suffered from the Deleting unused components problem on the production release site. Reason unknown. The ESP-IDF v5.2 was used for all development testing. Reminder that the exact same example code is used for all types of components: local install, ESP-IDF, and local Managed Components. Note that additional changes have been made to the publishing scripts. One problematic issue encountered with my first release site preview is that I used mixed case in the 5.7.4-preview1a. ( The latest preview release is currently 5.7.4-preview1e. Additional testing is still underway, but things are finally looking promising. |
Hi @gojimmypi I tried to reproduce the issue with ESP-IDF v5.2.3 and the component manager v2.1.0, but didn't manage to reproduce. Could you please help with the steps?
What kind of issue is caused by mixed casing? Can we do something on our side to avoid it? |
Hello @kumekay and thanks for taking a look at this. I'm using ESP-IDF
The only changes are some backup files: I also tried ESP-IDF With your To test my initial problematic preview version that deletes unused code, please use this syntax (note the
No changes made in I see this output:
Note that with automated testing without the interactive menuconfig, the examples compile, build, flash and run successfully. I searched through my ESP32 directory (used in WSL, but initially installed in Windows via ViasualGDB), but could find no reference to the code that is printing the "Deleting 1 unused component" message. Is is possibly that the
Regarding the case, note the contents of
The published Preview1a has a lower case
I did observe some inconsistencies, but I was primarily looking at the cause of component deletion.
Perhaps either enforce a case, or don't change them? My Cheers & thank you again for your help. |
Description
This PR updates the Espressif examples and builds on the updates in #8076. Enclosed are changes essential for the wolfSSL Managed Component examples to work properly with the v5.7.4-stable release of wolfssl.
Primary changes are to
CMakeLists.txt
andsdkconfig.defaults
. Only minor changes made to example code.Note this PR is based on the
bdd62314
release commit, and DOES NOT INCLUDE other wolfSSL post-release updates.The result will be an as-published wolfSSL 5.7.4 with only the changes needed for Espressif example updates. See my pr-post-release-bdd62314-espressif branch.
In particular, this PR addresses the new esp-tls and Certificate Bundle Support features introduced in #7936 and the respective interaction with Managed Components.
As not all versions of the ESP-IDF support the new
esp-tls
integration with wolfSSL, all of the examples now have the settings disabled by default in the respectivedkconfig.defaults
files:See my ESP-IDF v5.3.1 work and the respective release for PlatformIO.
To use it with PlatformIO, adjust this line in the
platformio.ini
file:I have an example with my esp_http_client_example.
Other Changes
There are some corrections to cmake
add_compile_definitions
syntax.Improved checks for Managed Component names (e.g. staging site user names &
mywolfssl
)Adds new
IS_GIT_REPO
check to avoid attempts to glean attributes from non-git directories, such as those in Managed Component examples.client-tls.c
changed theNoPeerCheck != 0
to be information, not a warning.TLS_SMP_CLIENT_TASK_BYTES
bumped up to 10K default, rather than 8K.sdk_init_meminfo();
is only disabled when available andDEBUG_WOLFSSL
enabled.The server example now gates out
this_heap
andstack_start
variables not used as appropriate.While testing and editing the cmake files, I also discovered instances of
message("text")
that were being sent tostderr
.I replaced those with
message(STATUS "text")
Various spelling corrections
Addresses zd# 18228
Testing
Much of the testing occurred with the staging instance under my user name.
At the moment, the staging site is giving me a "Bad Gateway" error.
See also the internal wolfSSL scripts. I've added additional diagnostics and automated testing.
Release
As of the date of this PR creation, the release wolfSSL Managed Component has NOT yet been published. I plan to publish preview releases soon.
Checklist