fix: due to buffering in the underlying stream reads are limited in size #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if you call `Read` and provide a buffer larger than a few k the stream returns only that few k, given the reader abstraction discards the stream between `Read` operations this results in many API calls. To mitigate this I moved back to retaining the stream from an optimistic get object which is configured when the file is opened, this then is used by subsquent read calls. This PR adds tests that illustrate the issue. One thing to note is using `Seek` closes the initial get object stream as this doesn't support these operations, and instead uses `ReadAt`, which results in more API calls.
wolfeidau
force-pushed
the
fix_large_reads_not_working
branch
from
ed9ea38
to
1e05bc6
Compare
wolfeidau
added a commit
to wolfeidau/iceberg-go
that referenced
this pull request
Jan 16, 2024
This resolves issues with endpoint changes in the SDK, see aws/aws-sdk-go-v2#2370, and upgrades s3iofs which has been upgraded to improve performance, see wolfeidau/s3iofs#25.
nastra
pushed a commit
to apache/iceberg-go
that referenced
this pull request
Jan 16, 2024
This resolves issues with endpoint changes in the SDK, see aws/aws-sdk-go-v2#2370, and upgrades s3iofs which has been upgraded to improve performance, see wolfeidau/s3iofs#25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you call
Readand provide a buffer larger than a few k the stream returns only that few k, given the reader abstraction discards the stream betweenReadoperations this results in many API calls.To mitigate this I moved back to retaining the stream from an optimistic get object which is performed when the file is opened, this then is used by subsquent read calls, and closed when the file is closed.
This PR adds tests that illustrate the issue.
One thing to note is using
Seekcloses the initial get object stream as this doesn't support these operations, and instead usesReadAt, which results in more API calls.