-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new pkg: aws-cli (v2), rename aws-cli to aws-cli-v1 #11127
Conversation
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
3458f98
to
b4c2c04
Compare
@ajayk can we get this reviewed? |
@tuananh will pick this up this week , sorry for the delay though |
Hi @tuananh can you please add the new package under aws-cli-v2 , leave the existing package as it is to avoid any confusions |
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
@ajayk updated as your recommendation as well as pumping up to latest version. verify it works with Not sure how to best handle this. we can add it in images like tomcat? https://github.com/chainguard-images/images/blob/da9ece7d56b69d00259cc20b31089c87805fdfb2/images/tomcat/config/template.apko.yaml#L72 |
Thanks for working on this @tuananh! According to your last comment, can we able to tackle scriptlets:
post-install: |
#!/bin/sh
echo
echo "WARNING: You need to run 'export LD_LIBRARY_PATH=/usr/lib/aws-cli' to use this package."
echo We can also add this in the image manifest for sure. |
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
Head branch was pushed to by a user without write access
Not sure how this got in
|
Tested by creating an apko image
I tried moving documentation to sub-package but apparently, they use it for
aws help
command. so we will need to ignore melange documentation linter as well.Fixes:
Related: #1848 #2272 #3884
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches