Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new pkg: aws-cli (v2), rename aws-cli to aws-cli-v1 #11127

Merged
merged 12 commits into from
Mar 25, 2024

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Jan 13, 2024

Tested by creating an apko image

image

I tried moving documentation to sub-package but apparently, they use it for aws help command. so we will need to ignore melange documentation linter as well.

Fixes:

Related: #1848 #2272 #3884

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

aws-cli.yaml Outdated Show resolved Hide resolved
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
@tuananh
Copy link
Contributor Author

tuananh commented Feb 2, 2024

@ajayk can we get this reviewed?

@ajayk
Copy link
Member

ajayk commented Feb 3, 2024

@tuananh will pick this up this week , sorry for the delay though

@ajayk
Copy link
Member

ajayk commented Mar 10, 2024

Hi @tuananh can you please add the new package under aws-cli-v2 , leave the existing package as it is to avoid any confusions

@tuananh
Copy link
Contributor Author

tuananh commented Mar 12, 2024

@ajayk updated as your recommendation as well as pumping up to latest version.

verify it works with LD_LIBRARY_PATH: /usr/lib/aws-cli. related issue: aws/aws-cli#5506

Not sure how to best handle this. we can add it in images like tomcat? https://github.com/chainguard-images/images/blob/da9ece7d56b69d00259cc20b31089c87805fdfb2/images/tomcat/config/template.apko.yaml#L72

@Dentrax
Copy link
Member

Dentrax commented Mar 21, 2024

Thanks for working on this @tuananh!

According to your last comment, can we able to tackle LD_LIBRARY_PATH issue using scriptlets?

scriptlets:
    post-install: |
      #!/bin/sh
      echo
      echo "WARNING: You need to run 'export LD_LIBRARY_PATH=/usr/lib/aws-cli' to use this package."
      echo

We can also add this in the image manifest for sure.

tuananh and others added 3 commits March 21, 2024 21:22
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
ajayk
ajayk previously approved these changes Mar 23, 2024
@ajayk ajayk enabled auto-merge March 23, 2024 16:55
Signed-off-by: Tuan Anh Tran <me@tuananh.org>
auto-merge was automatically disabled March 24, 2024 00:19

Head branch was pushed to by a user without write access

@tuananh
Copy link
Contributor Author

tuananh commented Mar 24, 2024

Not sure how this got in

Building package pgaudit-14 with version pgaudit-14-1.6.2-r1 from file ./pgaudit-14.yaml
make yamlfile=./pgaudit-14.yaml srcdirflag="--source-dir ./pgaudit-14" pkgname=pgaudit-14 packages/x86_64/pgaudit-14-1.6.2-r1.apk

@ajayk ajayk enabled auto-merge March 24, 2024 14:59
@ajayk ajayk merged commit d9f94bb into wolfi-dev:main Mar 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants