-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude-reason field to existing configs with comments. #23885
Conversation
We may need to split this up into batches so that the presubmit build can run fully. Also looks like the update check fails to unmarshal the |
Any prior art for how fine we should split this up? The lint failing sounds like a wolfictl bug. I can dig into it. |
We could try the big batch and see how it goes, at least we wont build new versions once it's merged to main as changes to the update block to not cause new apk versions to be built. The lint bug is fixed now yay thanks! On quick glance it looks like genuine lint errors. |
222b529
to
06cb479
Compare
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package.
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package. Related: chainguard-dev/mono#18290, wolfi-dev/wolfictl#1060, wolfi-dev#23885
Moves existing update field comments into new exclude-reason field. This is intented to track why auto-update is disabled for a particular package.
Related: https://github.com/chainguard-dev/mono/issues/18290, https://github.com/wolfi-dev/wolfictl/pull/1060/files
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latest
successfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches