Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: add more checks #40247

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

imjasonh
Copy link
Member

No description provided.

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

imjasonh commented Jan 22, 2025

This currently fails:

$ pre-commit run --all-files
detect private key.......................................................Failed
- hook id: detect-private-key
- exit code: 1

Private key found: ruby-3.0/0001-ruby-3.0.6-openssl-patch.patch

https://github.com/wolfi-dev/os/blob/main/ruby-3.0/0001-ruby-3.0.6-openssl-patch.patch

@imjasonh
Copy link
Member Author

@dannf I'm not sure what we want to do about the Ruby patch. I believe we can configure an exemption for it, or we can remove the check entirely for this repo, or we can update the patch (which I'm less comfortable with)

@dannf
Copy link
Member

dannf commented Jan 22, 2025

@dannf I'm not sure what we want to do about the Ruby patch. I believe we can configure an exemption for it, or we can remove the check entirely for this repo, or we can update the patch (which I'm less comfortable with)

+1 on an exemption - I think we can do something like:

  - id: detect-private-key
    exclude: ^ruby-3\.0/0001-ruby-3\.0\.6-openssl-patch\.patch$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants