fix(osv): move aliases to related field #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See google/osv.dev#2374 for motivation. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
imjasonh
approved these changes
Jul 9, 2024
Comment on lines
+151
to
+153
| // Note: The OSV data should include our advisory ID itself among the listed | ||
| // related vulnerability IDs. | ||
| related := append([]string{adv.ID}, adv.Aliases...) |
There was a problem hiding this comment.
Hi,
I just wanted to ask why you include the advisory's own ID in its related (or aliases) field.
It seems a bit odd to make a record link to itself, but it seem like an intentional decision?
There was a problem hiding this comment.
was my understanding in the beginning to add that as is. maybe i got that wrong
There was a problem hiding this comment.
Yeah it sounded like this was feedback from the OSV team — originally we didn't add in the ID itself to this collection. Happy to remove it if it's not needed! 🧹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See google/osv.dev#2374 for motivation.
cc: @cpanato