Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vkCmdWriteTimestamp overwrite issues #799

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix vkCmdWriteTimestamp overwrite issues #799

merged 1 commit into from
May 25, 2024

Conversation

heyallnorahere
Copy link
Contributor

This change:

  • Adds the VK_QUERY_RESULT_WITH_AVAILABILITY_BIT to the vkGetQueryPoolResults call, encoding extra data at the cost of a larger buffer (see docs)
  • Checks that each query has been completed, and when the profiler finds a query that has not, it delays the reporting until the next time Collect() is called

Should solve #663

@wolfpld wolfpld merged commit f8524f8 into wolfpld:master May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyallnorahere @wolfpld