Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crystal 1.14.0 compilation error undefined constant ConnectionBuilder #21

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix Crystal 1.14.0 compilation error undefined constant ConnectionBuilder #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bdec54
Fix `undefined constant ConnectionBuilder` compilation error
lachlan Oct 11, 2024
c9a2366
Fix `sleep(Number)` deprecation compilation warning
lachlan Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/spec_helper.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def connect(connection_string)
return DB.open(uri)
rescue exc : DB::ConnectionRefused
raise exc if Time.local > expiry
sleep(5)
sleep(5.seconds)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions src/tds/driver.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class TDS::Driver < DB::Driver
class TDS::ConnectionBuilder < DB::ConnectionBuilder
class ConnectionBuilder < DB::ConnectionBuilder
def initialize(@options : DB::Connection::Options, @tds_options : TDS::Connection::Options)
end

Expand All @@ -10,7 +10,7 @@ class TDS::Driver < DB::Driver

def connection_builder(uri : URI) : DB::ConnectionBuilder
params = HTTP::Params.parse(uri.query || "")
ConnectionBuilder.new(connection_options(params), TDS::Connection::Options.from_uri(uri))
TDS::Driver::ConnectionBuilder.new(connection_options(params), TDS::Connection::Options.from_uri(uri))
end
end

Expand Down