Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools selection via keyboard is slow #1186

Closed
audionerd opened this issue May 30, 2018 · 0 comments
Closed

Tools selection via keyboard is slow #1186

audionerd opened this issue May 30, 2018 · 0 comments
Assignees
@audionerd
Labels
enhancement
Milestone
V2

Comments

@audionerd
Copy link
Member

audionerd commented May 30, 2018 •
edited
Loading

Tool selection via keyboard routes through Menu, which I'm guessing is causing the lag (or IPC?).

We could maybe catch the input via before-input-event and disable the menu command while still letting the key event through? So menu shows key label and can be clicked directly but DOES NOT actually respond to key command.

And: when typing in the sidebar, menu is triggering, which is not what we want! (fixed)

Reference
https://electronjs.org/docs/api/web-contents#event-before-input-event
electron/electron#1334
https://github.com/WilixLead/iohook
@audionerd audionerd added this to the Post-V2 milestone May 30, 2018
@audionerd audionerd self-assigned this May 30, 2018
@audionerd audionerd modified the milestones: Post-V2, V2 Jun 8, 2018
audionerd added a commit that referenced this issue Jun 8, 2018
@audionerd
prevent menu from triggering on text field input
5bc146e 
related to #1186
audionerd added a commit that referenced this issue Jun 12, 2018
@audionerd
intercept tool keys
7e8c3ed 
fixes #1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@audionerd audionerd

Labels
enhancement
Projects
None yet
Milestone
V2
Development

No branches or pull requests
1 participant
@audionerd