PHPCS fixes: WordPress and WooCommerce

classes/ActionScheduler_AdminView.php

@@ -35,7 +35,7 @@ public static function instance() {
 	 * @codeCoverageIgnore
 	 */
 	public function init() {
-		if ( is_admin() && ( ! defined( 'DOING_AJAX' ) || false == DOING_AJAX ) ) {
+		if ( is_admin() && ( ! defined( 'DOING_AJAX' ) || false === DOING_AJAX ) ) {
 
 			if ( class_exists( 'WooCommerce' ) ) {
 				add_action( 'woocommerce_admin_status_content_action-scheduler', array( $this, 'render_admin_ui' ) );
@@ -200,13 +200,19 @@ protected function check_pastdue_actions() {
 		echo '<div class="notice notice-warning"><p>';
 		printf(
 			// translators: 1) is the number of affected actions, 2) is a link to an admin screen.
-			_n(
-				'<strong>Action Scheduler:</strong> %1$d <a href="%2$s">past-due action</a> found; something may be wrong. <a href="https://actionscheduler.org/faq/#my-site-has-past-due-actions-what-can-i-do" target="_blank">Read documentation &raquo;</a>',
-				'<strong>Action Scheduler:</strong> %1$d <a href="%2$s">past-due actions</a> found; something may be wrong. <a href="https://actionscheduler.org/faq/#my-site-has-past-due-actions-what-can-i-do" target="_blank">Read documentation &raquo;</a>',
-				$num_pastdue_actions,
-				'action-scheduler'
+			wp_kses(
+				_n(
+					'<strong>Action Scheduler:</strong> %1$d <a href="%2$s">past-due action</a> found; something may be wrong. <a href="https://actionscheduler.org/faq/#my-site-has-past-due-actions-what-can-i-do" target="_blank">Read documentation &raquo;</a>',
+					'<strong>Action Scheduler:</strong> %1$d <a href="%2$s">past-due actions</a> found; something may be wrong. <a href="https://actionscheduler.org/faq/#my-site-has-past-due-actions-what-can-i-do" target="_blank">Read documentation &raquo;</a>',
+					$num_pastdue_actions,
+					'action-scheduler'
+				),
+				array(
+					'strong' => array(),
+					'a'      => array( 'href', 'target' ),
+				)
 			),
-			$num_pastdue_actions,
+			absint( $num_pastdue_actions ),
 			esc_attr( esc_url( $actions_url ) )
 		);
 		echo '</p></div>';
@@ -221,7 +227,7 @@ protected function check_pastdue_actions() {
 	public function add_help_tabs() {
 		$screen = get_current_screen();
 
-		if ( ! $screen || self::$screen_id != $screen->id ) {
+		if ( ! $screen || self::$screen_id !== $screen->id ) {
 			return;
 		}
 

classes/ActionScheduler_AsyncRequest_QueueRunner.php

@@ -11,23 +11,20 @@ class ActionScheduler_AsyncRequest_QueueRunner extends WP_Async_Request {
 	 * Data store for querying actions
 	 *
 	 * @var ActionScheduler_Store
-	 * @access protected
 	 */
 	protected $store;
 
 	/**
 	 * Prefix for ajax hooks
 	 *
 	 * @var string
-	 * @access protected
 	 */
 	protected $prefix = 'as';
 
 	/**
 	 * Action for ajax hooks
 	 *
 	 * @var string
-	 * @access protected
 	 */
 	protected $action = 'async_request_queue_runner';
 

classes/ActionScheduler_DateTime.php

@@ -15,7 +15,7 @@ class ActionScheduler_DateTime extends DateTime {
 	 *
 	 * @var int
 	 */
-	protected $utcOffset = 0;
+	protected $utc_offset = 0;
 
 	/**
 	 * Get the unix timestamp of the current object.
@@ -37,7 +37,7 @@ public function getTimestamp() {
 	 * @param string|int $offset UTC offset value.
 	 */
 	public function setUtcOffset( $offset ) {
-		$this->utcOffset = intval( $offset );
+		$this->utc_offset = intval( $offset );
 	}
 
 	/**
@@ -48,7 +48,7 @@ public function setUtcOffset( $offset ) {
 	 */
 	#[\ReturnTypeWillChange]
 	public function getOffset() {
-		return $this->utcOffset ? $this->utcOffset : parent::getOffset();
+		return $this->utc_offset ? $this->utc_offset : parent::getOffset();
 	}
 
 	/**
@@ -61,7 +61,7 @@ public function getOffset() {
 	 */
 	#[\ReturnTypeWillChange]
 	public function setTimezone( $timezone ) {
-		$this->utcOffset = 0;
+		$this->utc_offset = 0;
 		parent::setTimezone( $timezone );
 
 		return $this;

classes/ActionScheduler_FatalErrorMonitor.php

@@ -70,8 +70,8 @@ public function handle_unexpected_shutdown() {
 		$error = error_get_last();
 
 		if ( $error ) {
-			if ( in_array( $error['type'], array( E_ERROR, E_PARSE, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR ) ) ) {
-				if ( !empty($this->action_id) ) {
+			if ( in_array( $error['type'], array( E_ERROR, E_PARSE, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR ), true ) ) {
+				if ( ! empty($this->action_id) ) {
 					$this->store->mark_failure( $this->action_id );
 					do_action( 'action_scheduler_unexpected_shutdown', $this->action_id, $error );
 				}

classes/ActionScheduler_InvalidActionException.php

@@ -21,7 +21,7 @@ public static function from_schedule( $action_id, $schedule ) {
 			/* translators: 1: action ID 2: schedule */
 			__( 'Action [%1$s] has an invalid schedule: %2$s', 'action-scheduler' ),
 			$action_id,
-			var_export( $schedule, true )
+			var_export( $schedule, true ) // phpcs:ignore WordPress.PHP.DevelopmentFunctions
 		);
 
 		return new static( $message );
@@ -30,8 +30,6 @@ public static function from_schedule( $action_id, $schedule ) {
 	/**
 	 * Create a new exception when the action's args cannot be decoded to an array.
 	 *
-	 * @author Jeremy Pry
-	 *
 	 * @param string $action_id The action ID with bad args.
 	 * @param mixed  $args      Passed arguments.
 	 * @return static
@@ -41,7 +39,7 @@ public static function from_decoding_args( $action_id, $args = array() ) {
 			/* translators: 1: action ID 2: arguments */
 			__( 'Action [%1$s] has invalid arguments. It cannot be JSON decoded to an array. $args = %2$s', 'action-scheduler' ),
 			$action_id,
-			var_export( $args, true )
+			var_export( $args, true ) // phpcs:ignore WordPress.PHP.DevelopmentFunctions
 		);
 
 		return new static( $message );

classes/ActionScheduler_ListTable.php

@@ -118,16 +118,16 @@ public function __construct( ActionScheduler_Store $store, ActionScheduler_Logge
 
 		if ( empty( $request_status ) ) {
 			$this->sort_by[] = 'status';
-		} elseif ( in_array( $request_status, array( 'in-progress', 'failed' ) ) ) {
+		} elseif ( in_array( $request_status, array( 'in-progress', 'failed' ), true ) ) {
 			$this->columns  += array( 'claim_id' => __( 'Claim ID', 'action-scheduler' ) );
 			$this->sort_by[] = 'claim_id';
 		}
 
 		$this->row_actions = array(
 			'hook' => array(
-				'run' => array(
-					'name'  => __( 'Run', 'action-scheduler' ),
-					'desc'  => __( 'Process the action now as if it were run as part of a queue', 'action-scheduler' ),
+				'run'    => array(
+					'name' => __( 'Run', 'action-scheduler' ),
+					'desc' => __( 'Process the action now as if it were run as part of a queue', 'action-scheduler' ),
 				),
 				'cancel' => array(
 					'name'  => __( 'Cancel', 'action-scheduler' ),
@@ -331,7 +331,7 @@ protected function get_log_entry_html( ActionScheduler_LogEntry $log_entry, Date
 	 * @return string
 	 */
 	protected function maybe_render_actions( $row, $column_name ) {
-		if ( 'pending' === strtolower( $row[ 'status_name' ] ) ) {
+		if ( 'pending' === strtolower( $row['status_name'] ) ) {
 			return parent::maybe_render_actions( $row, $column_name );
 		}
 
@@ -359,7 +359,7 @@ public function display_admin_notices() {
 
 			$found_tables = $wpdb->get_col( "SHOW TABLES LIKE '{$wpdb->prefix}actionscheduler%'" ); // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
 			foreach ( $table_list as $table_name ) {
-				if ( ! in_array( $wpdb->prefix . $table_name, $found_tables ) ) {
+				if ( ! in_array( $wpdb->prefix . $table_name, $found_tables, true ) ) {
 					$this->admin_notices[] = array(
 						'class'   => 'error',
 						'message' => __( 'It appears one or more database tables were missing. Attempting to re-create the missing table(s).' , 'action-scheduler' ),
@@ -414,7 +414,7 @@ public function display_admin_notices() {
 
 			$action = $this->store->fetch_action( $notification['action_id'] );
 			$action_hook_html = '<strong><code>' . $action->get_hook() . '</code></strong>';
-			if ( 1 == $notification['success'] ) {
+			if ( 1 === absint( $notification['success'] ) ) {
 				$class = 'updated';
 				switch ( $notification['row_action_type'] ) {
 					case 'run' :

classes/ActionScheduler_LogEntry.php

@@ -8,12 +8,12 @@ class ActionScheduler_LogEntry {
 	/**
 	 * @var int $action_id
 	 */
-	protected $action_id =  '';
+	protected $action_id = '';
 
 	/**
 	 * @var string $message
 	 */
-	protected $message =  '';
+	protected $message = '';
 
 	/**
 	 * @var Datetime $date
@@ -43,7 +43,7 @@ public function __construct( $action_id, $message, $date = null ) {
 
 		$this->action_id = $action_id;
 		$this->message   = $message;
-		$this->date      = $date ? $date : new Datetime;
+		$this->date      = $date ? $date : new Datetime();
 	}
 
 	/**

classes/ActionScheduler_QueueCleaner.php

@@ -86,8 +86,8 @@ public function delete_old_actions() {
 	 * @return array Actions deleted.
 	 */
 	public function clean_actions( array $statuses_to_purge, DateTime $cutoff_date, $batch_size = null, $context = 'old' ) {
-		$batch_size = $batch_size !== null ? $batch_size : $this->batch_size;
-		$cutoff     = $cutoff_date !== null ? $cutoff_date : as_get_datetime_object( $this->month_in_seconds . ' seconds ago' );
+		$batch_size = ! is_null( $batch_size ) ? $batch_size : $this->batch_size;
+		$cutoff     = ! is_null( $cutoff_date ) ? $cutoff_date : as_get_datetime_object( $this->month_in_seconds . ' seconds ago' );
 		$lifespan   = time() - $cutoff->getTimestamp();
 		if ( empty( $statuses_to_purge ) ) {
 			$statuses_to_purge = $this->default_statuses_to_purge;
@@ -119,7 +119,7 @@ public function clean_actions( array $statuses_to_purge, DateTime $cutoff_date,
 	 */
 	private function delete_actions( array $actions_to_delete, $lifespan = null, $context = 'old' ) {
 		$deleted_actions = [];
-		if ( $lifespan === null ) {
+		if ( is_null( $lifespan ) ) {
 			$lifespan = $this->month_in_seconds;
 		}
 
@@ -209,7 +209,6 @@ public function mark_failures( $time_limit = 300 ) {
 	 * Do all of the cleaning actions.
 	 *
 	 * @param int $time_limit The number of seconds to use as the timeout and failure period. Default 300 (5 minutes).
-	 * @author Jeremy Pry
 	 */
 	public function clean( $time_limit = 300 ) {
 		$this->delete_old_actions();
@@ -220,7 +219,6 @@ public function clean( $time_limit = 300 ) {
 	/**
 	 * Get the batch size for cleaning the queue.
 	 *
-	 * @author Jeremy Pry
 	 * @return int
 	 */
 	protected function get_batch_size() {

classes/ActionScheduler_QueueRunner.php

@@ -52,6 +52,7 @@ public function __construct( ActionScheduler_Store $store = null, ActionSchedule
 	 */
 	public function init() {
 
+		// phpcs:ignore WordPress.WP.CronInterval.CronSchedulesInterval
 		add_filter( 'cron_schedules', array( self::instance(), 'add_wp_cron_schedule' ) );
 
 		// Check for and remove any WP Cron hook scheduled by Action Scheduler < 3.0.0, which didn't include the $context param.
@@ -163,8 +164,8 @@ protected function do_batch( $size = 100, $context = '' ) {
 		$processed_actions = 0;
 
 		foreach ( $claim->get_actions() as $action_id ) {
-			// bail if we lost the claim.
-			if ( ! in_array( $action_id, $this->store->find_actions_by_claim_id( $claim->get_id() ) ) ) {
+			// bail if we lost the claim
+			if ( ! in_array( $action_id, $this->store->find_actions_by_claim_id( $claim->get_id() ), true ) ) {
 				break;
 			}
 			$this->process_action( $action_id, $context );

classes/ActionScheduler_Versions.php

@@ -19,10 +19,10 @@ class ActionScheduler_Versions {
 	 * @param callable $initialization_callback Callback to initialize the version.
 	 */
 	public function register( $version_string, $initialization_callback ) {
-		if ( isset($this->versions[$version_string]) ) {
+		if ( isset($this->versions[ $version_string ]) ) {
 			return FALSE;
 		}
-		$this->versions[$version_string] = $initialization_callback;
+		$this->versions[ $version_string ] = $initialization_callback;
 		return TRUE;
 	}
 
@@ -50,10 +50,10 @@ public function latest_version() {
 	 */
 	public function latest_version_callback() {
 		$latest = $this->latest_version();
-		if ( empty($latest) || !isset($this->versions[$latest]) ) {
+		if ( empty($latest) || ! isset($this->versions[ $latest ]) ) {
 			return '__return_null';
 		}
-		return $this->versions[$latest];
+		return $this->versions[ $latest ];
 	}
 
 	/**

classes/ActionScheduler_WPCommentCleaner.php

@@ -66,7 +66,11 @@ public static function has_logs() {
 	 * Attached to the migration complete hook 'action_scheduler/migration_complete'.
 	 */
 	public static function maybe_schedule_cleanup() {
-		if ( (bool) get_comments( array( 'type' => ActionScheduler_wpCommentLogger::TYPE, 'number' => 1, 'fields' => 'ids' ) ) ) {
+		if ( (bool) get_comments( array(
+			'type'   => ActionScheduler_wpCommentLogger::TYPE,
+			'number' => 1,
+			'fields' => 'ids',
+		) ) ) {
 			update_option( self::$has_logs_option_key, 'yes' );
 
 			if ( ! as_next_scheduled_action( self::$cleanup_hook ) ) {
@@ -80,7 +84,10 @@ public static function maybe_schedule_cleanup() {
 	 */
 	public static function delete_all_action_comments() {
 		global $wpdb;
-		$wpdb->delete( $wpdb->comments, array( 'comment_type' => ActionScheduler_wpCommentLogger::TYPE, 'comment_agent' => ActionScheduler_wpCommentLogger::AGENT ) );
+		$wpdb->delete( $wpdb->comments, array(
+			'comment_type'  => ActionScheduler_wpCommentLogger::TYPE,
+			'comment_agent' => ActionScheduler_wpCommentLogger::AGENT,
+		) );
 		delete_option( self::$has_logs_option_key );
 	}
 

classes/WP_CLI/ActionScheduler_WPCLI_Clean_Command.php

@@ -41,7 +41,7 @@ public function clean( $args, $assoc_args ) {
 
 		$batches_completed = 0;
 		$actions_deleted   = 0;
-		$unlimited         = $batches === 0;
+		$unlimited         = 0 === $batches;
 		try {
 			$lifespan = as_get_datetime_object( $before );
 		} catch ( Exception $e ) {