Add unit tests for the has_pending_actions_due method #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreymckrill
requested review from
naman03malhotra
and removed request for
a team
barryhughes
force-pushed
the
add/has-pending-unit-tests
branch
from
4e31971
to
bb1fc54
Compare
naman03malhotra
approved these changes
Sep 5, 2024
coreymckrill
force-pushed
the
add/has-pending-unit-tests
branch
from
bb1fc54
to
e6eadd1
Compare
In #1077 we're making some performance improvements to the `has_pending_actions_due` method, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.
coreymckrill
force-pushed
the
add/has-pending-unit-tests
branch
from
66f858d
to
dd1550c
Compare
|
More progress: keep it going! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1077 we're making some performance improvements to the
has_pending_actions_duemethod, but there are no unit tests to protect against regressions, so this is simply adding some. Because the tests are in the abstract class, they will get run for each data store type.