Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First number of phone verification is not cleared when clicking "Resend…" button #1002

Closed
tomalec opened this issue Sep 9, 2021 · 1 comment · Fixed by #1007
Closed

First number of phone verification is not cleared when clicking "Resend…" button #1002

tomalec opened this issue Sep 9, 2021 · 1 comment · Fixed by #1007
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.

Comments

@tomalec
Copy link
Member

tomalec commented Sep 9, 2021

(This is a belated follow up from #993)

Describe the bug:

When I click "Resend code" button all the inputs are cleared except the first one, then the number is cleared when I move the focus away.

first

Expected behavior:

All numbers should be cleared.

Actual behavior:

The first one is still there.

Steps to reproduce:

  1. Go to phone verification settings /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsettings
  2. Click "Send verification code"
  3. Type 123456
  4. Click "Resend code" (once ready)
  5. 🟥 the 1 is still there
  6. Click somewhere, to move focus away from the focused first field.

Additional details:
@tomalec tomalec added type: bug The issue is a confirmed bug. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels Sep 9, 2021
@tomalec tomalec mentioned this issue Sep 9, 2021
Merged
1 task
@eason9487
Copy link
Member

I think it was introduced by the value={ value } in 808e70e. 🤦‍♂️

eason9487 added a commit that referenced this issue Sep 10, 2021
@eason9487
Fix that the first verification code input isn't cleared after resetting
305c21c 
Address #1002
@eason9487 eason9487 mentioned this issue Sep 10, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues and react warnings for verification code components woocommerce/google-listings-and-ads
2 participants
@tomalec @eason9487