Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backspace does not remove selected verification code number #1003

Closed
tomalec opened this issue Sep 9, 2021 · 0 comments · Fixed by #1007
Closed

Backspace does not remove selected verification code number #1003

tomalec opened this issue Sep 9, 2021 · 0 comments · Fixed by #1007
Labels
category: accessibility The issue/PR is related to accessibility. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.

Comments

@tomalec
Copy link
Member

tomalec commented Sep 9, 2021

(This is a belated follow up from #993)

Describe the bug:

When I select a number and click backspace, the focus is moved back, but the number is not removed.

Expected behavior:

Backspace removes the selection and moves the caret back(left).

Actual behavior:

Caret Is moved, but the number is not deleted.

Steps to reproduce:

  1. Go to phone verification settings /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsettings
  2. Click "Send verification code"
  3. Input 123456
  4. Select any number from 2-6
  5. Click backspace

backspace

This is even more disturbing when navigating the using keyboard-only:

  1. Input 123456
  2. Click tab
  3. Click shift + tab
  4. Click backspace

backspace2

Additional details:
@tomalec tomalec added type: bug The issue is a confirmed bug. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. category: accessibility The issue/PR is related to accessibility. labels Sep 9, 2021
@tomalec tomalec mentioned this issue Sep 9, 2021
Merged
1 task
eason9487 added a commit that referenced this issue Sep 10, 2021
@eason9487
Fix that backspace doson't remove selected digit in the VerificationC…
2188f60 
…odeControl

Address #1003
@eason9487 eason9487 mentioned this issue Sep 10, 2021
Merged
1 task
@eason9487 eason9487 linked a pull request Sep 10, 2021 that will close this issue
Fix issues and react warnings for verification code components #1007
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: accessibility The issue/PR is related to accessibility. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues and react warnings for verification code components woocommerce/google-listings-and-ads
1 participant
@tomalec