-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Campaign Creation: Update Budget Setup Card #2502
Comments
Adding a note for this solution. The initial budget for campaign creation also needs to be fetched for the
|
@eason9487 good note. I wonder if rather than trying to use |
Along with #2501, I expect this processing will be removed together as Therefore, I would suggest not adding additional logic to |
👍🏻 Sounds good.
This was my initial instinct as well. The downside to this approach is that if there are different forms that include the |
After further discussion, we'll only need to set an initial value when creating a campaign, and not when editing, so handling this in the form rather than the |
I didn't set any assignee as I'm not sure who is working on this ticket. |
Part of #2459
For the Budget card, we want to explain to users that:
Also, the warning message of “With a budget lower than your competitor range, your campaign may not get noticeable results.” appears from the start, before putting any number. Merchants might not connect that warning message to the actual budget they’re putting afterwards.
To set proper expectations with users we will automatically start with a the input set at the minimum recommended value and hide the initial budget warning from this card.
We'll also update the copy in the blue box to read something like this:
The recommendation amount will still be location-based as it is currently.
Acceptance Criteria
We recommend running campaigns at least 1 month so it can learn to optimize for your business. Tip: Most merchants targeting United States (US) set a daily budget of $%d USD.
, where %d is replaced by the recommended daily budget.Implementation Brief
The budget warning is already wired up so that it won't show if the daily average cost is higher than the recommended daily average, so the main thing to solve here is to ensure the initial form value is set to the recommended value.
The
BudgetRecommendations
component makes use of theuseFetchBudgetRecommendationEffect()
hook to fetch the current recommendations. This will need to be moved up to thePaidAdsSetupSections
component. Currently the default amount for campaigns is set to0
here. This can be set using theuseFetchBudgetRecommendationEffect()
value.Note for testing: when this screen is loaded, the last value set gets stored in session storage in a
gla-onboarding-paid-ads
key. This will need to be cleared in order to see changes.The budget recommendations copy for both the warning and the tip (blue box) can be edited in
js/src/components/paid-ads/budget-section/budget-recommendation/index.js
.Test Coverage
E2E tests for
tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js
need to be updated to confirm the behavior of the initial value, the visibility of the budget warning, and any tests confirming the copy of the budget tip needs to be updated.The text was updated successfully, but these errors were encountered: