Update Budget Setup Card. #2552

ankitrox · 2024-08-22T06:15:53Z

Changes proposed in this Pull Request:

Closes #2502 .

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Proceed with the onboarding flow and complete first 3 steps of the onboarding flow.
On the 4th step, notice that Daily average cost input will have the pre-populated value with highest budget in the recommended budgets. For example:

If UAE (14 USD), Hong Kong (6 USD)and Vietnam (5 USD) are selected, the input should be populated with 14.00

If you remove UAE from list of countries, the help text should get updated with the next highest value like Most merchants targeting similar countries set a daily budget of 6 USD (As next highest value is 6).

Additional details:

Changelog entry

Update - Change the campaign setup in the onboarding to use the recommended budget as the initial value and adjust its description.

codecov · 2024-08-22T06:18:28Z

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes missing coverage. Please review.

Project coverage is 63.5%. Comparing base (5d5ed13) to head (ab2db99).
Report is 1 commits behind head on feature/2459-campaign-creation-flow.

Files with missing lines	Patch %	Lines
js/src/hooks/useBudgetRecommendationData.js	6.7%	13 Missing and 1 partial ⚠️
js/src/utils/getHighestBudget.js	0.0%	6 Missing and 2 partials ⚠️
js/src/components/paid-ads/ads-campaign.js	0.0%	2 Missing and 3 partials ⚠️
...-ads/budget-section/budget-recommendation/index.js	0.0%	3 Missing ⚠️
js/src/pages/create-paid-ads-campaign/index.js	0.0%	2 Missing and 1 partial ⚠️
js/src/components/paid-ads/budget-section/index.js	0.0%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2552     +/-   ##
=====================================================================
- Coverage                                 63.8%   63.5%   -0.3%     
=====================================================================
  Files                                      326     329      +3     
  Lines                                     5089    5117     +28     
  Branches                                  1231    1238      +7     
=====================================================================
+ Hits                                      3245    3249      +4     
- Misses                                    1676    1695     +19     
- Partials                                   168     173      +5

Flag	Coverage Δ
js-unit-tests	`63.5% <2.8%> (-0.3%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
js/src/hooks/useFetchBudgetRecommendationEffect.js	`20.0% <ø> (ø)`
js/src/components/paid-ads/budget-section/index.js	`12.5% <0.0%> (+2.0%)`	⬆️
...-ads/budget-section/budget-recommendation/index.js	`6.2% <0.0%> (+2.2%)`	⬆️
js/src/pages/create-paid-ads-campaign/index.js	`10.0% <0.0%> (-0.8%)`	⬇️
js/src/components/paid-ads/ads-campaign.js	`0.0% <0.0%> (ø)`
js/src/utils/getHighestBudget.js	`0.0% <0.0%> (ø)`
js/src/hooks/useBudgetRecommendationData.js	`6.7% <6.7%> (ø)`

... and 1 file with indirect coverage changes

joemcgill

This is looking really good, but issues I've noted a few issues where this could be improved.

joemcgill · 2024-08-26T22:32:45Z

tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js

@@ -266,16 +284,11 @@ test.describe( 'Complete your campaign', () => {
 							textContent
 						);

-					const responsePromise =


Why do we no longer need to wait for this response after the country setting is changed? It looks like when the country values change, the text that reads "Tip: Most merchants targeting similar countries set a daily budget of %d USD" does change, so we should probably ensure that is still being tested.

@ankitrox I'm still unsure why we need to remove this. Could you clarify?

js/src/components/paid-ads/budget-section/budget-recommendation/index.js

tests/e2e/utils/pages/setup-ads/setup-budget.js

ankitrox · 2024-08-28T06:09:25Z

Thank you @joemcgill for your feedback.

I've addressed your comments and responded to one of your comments related to removing the response promise here.

Please let me know if there's anything else you want me to look into. Over to you for another round of review.

Thanks again!

joemcgill

@ankitrox I'm still seeing some unexpected behavior with these changes. If you go back to a previous step after after the budget recommendations have been displayed and then return to the last step, the budget recommendations are no longer showing. I've added a video to show what I'm seeing. Can you give this another look?

budget-card.mov

Could you also provide more context for this question about the e2e test changes?

ankitrox · 2024-08-30T11:38:22Z

@joemcgill
Thanks for the video. It helped me understand the issue well.

The issue was happening because PaidAdsSetupSections component was getting rendered before recommendationData is resolved.

There was also an issue of amount getting changed to dailyBudget even if user has entered some value previously which gets stored in sessionStorage. This has been fixed now.

joemcgill

Thanks @ankitrox. This looks like it's working better now. I still have a question about one of the E2E changes that you made, which would be good to clarify, but I'm going to approve and send to @ankitguptaindia for QA.

joemcgill · 2024-09-01T18:39:20Z

tests/e2e/specs/setup-mc/step-4-complete-campaign.test.js

@@ -266,16 +284,11 @@ test.describe( 'Complete your campaign', () => {
 							textContent
 						);

-					const responsePromise =


@ankitrox I'm still unsure why we need to remove this. Could you clarify?

ankitrox · 2024-09-02T07:28:45Z

Hi @joemcgill

Apologies for missing the comment previously.

I have responded to the query here

ankitguptaindia · 2024-09-04T14:39:32Z

QA/Test Report- ✅

Testing Environment -

WordPress: 6.6.1
Theme active on store: Twenty Twenty-Four Version: 1.2
WooCommerce - Version 9.2.3
PHP: 8.3
Web Server: Nginx
Browser: Chrome - Version 127
OS: macOS Sonoma 14.6.1

Test Results -

Changes are working as expected. tested all related test scenarios and all are working well.

Functional Demo / Screencast -

Recording.812.mp4

eason9487

Left some suggestions, questions, and issues that need to be resolved.

In addition, if I understand correctly, post-onboarding can still select audience countries when creating a campaign via the /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&subpath=%2Fcampaigns%2Fcreate path.

However, there are now two issues with this page:

The recommended budget block is not shown
There is no API triggered to get the recommended budget after changing the audience countries.

eason9487 · 2024-09-06T05:09:01Z

js/src/components/paid-ads/budget-section/index.js

@@ -93,6 +93,8 @@ const BudgetSection = ( { formProps, disabled = false, children } ) => {
 							<BudgetRecommendation
 								countryCodes={ countryCodes }
 								dailyAverageCost={ amount }
+								currency={ currency }


BudgetRecommendation component doesn't use the currency prop.

eason9487 · 2024-09-06T05:21:04Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

@@ -11,6 +11,7 @@ import { Form } from '@woocommerce/components';
 import useGoogleAdsAccount from '.~/hooks/useGoogleAdsAccount';
 import useTargetAudienceFinalCountryCodes from '.~/hooks/useTargetAudienceFinalCountryCodes';
 import useGoogleAdsAccountBillingStatus from '.~/hooks/useGoogleAdsAccountBillingStatus';
+import useFetchBudgetRecommendationEffect from '.~/components/paid-ads/budget-section/budget-recommendation/useFetchBudgetRecommendationEffect';


What I understand is that the same logic of setting the default budget will then be applied to all ad creation forms, so moving the useFetchBudgetRecommendationEffect hook to the .~/hooks directory would be more appropriate.

eason9487 · 2024-09-06T05:35:31Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

@@ -78,6 +96,14 @@ export default function PaidAdsSetupSections( { onStatesReceived } ) {
 	const { hasGoogleAdsConnection } = useGoogleAdsAccount();
 	const { data: targetAudience } = useTargetAudienceFinalCountryCodes();
 	const { billingStatus } = useGoogleAdsAccountBillingStatus();
+	const { data: recommendationData } =
+		useFetchBudgetRecommendationEffect( targetAudience );


It may cause API to fail with a 400 bad request error.

Steps:

Proceed to onboarding step 4

Refresh webpage

eason9487 · 2024-09-06T05:44:16Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

+				currentPaidAds = {
+					...currentPaidAds,
+					amount: sessionAmount || dailyBudget,
+					recommendationData,


Wonder why recommendationData needs to be a part of the paidAds state?

eason9487 · 2024-09-06T05:59:17Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

@@ -143,6 +184,7 @@ export default function PaidAdsSetupSections( { onStatesReceived } ) {
 	const initialValues = {
 		countryCodes: paidAds.countryCodes,
 		amount: paidAds.amount,
+		recommendationData: paidAds.recommendationData,


The recommendationData is not used as the form value, so passing it around this way is not ideal.

eason9487 · 2024-09-06T06:04:04Z

js/src/components/paid-ads/budget-section/budget-recommendation/index.js

+		recommendations.filter( ( recommendation ) =>
+			countryCodes.includes( recommendation.country )
+		)


I'm curious about in which case it needs this filter?

eason9487 · 2024-09-06T06:09:26Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

+/*
+ * If a merchant selects more than one country, the budget recommendation
+ * takes the highest country out from the selected countries.
+ *
+ * For example, a merchant selected Brunei (20 USD) and Croatia (15 USD),
+ * then the budget recommendation should be (20 USD).
+ */
+function getHighestBudget( recommendations ) {
+	return recommendations.reduce( ( defender, challenger ) => {
+		if ( challenger.daily_budget > defender.daily_budget ) {
+			return challenger;
+		}
+		return defender;
+	} );
+}


This function is completely the same as:

google-listings-and-ads/js/src/components/paid-ads/budget-section/budget-recommendation/index.js

Lines 15 to 29 in 096c086

/*

* If a merchant selects more than one country, the budget recommendation

* takes the highest country out from the selected countries.

*

* For example, a merchant selected Brunei (20 USD) and Croatia (15 USD),

* then the budget recommendation should be (20 USD).

*/

function getHighestBudget( recommendations ) {

return recommendations.reduce( ( defender, challenger ) => {

if ( challenger.daily_budget > defender.daily_budget ) {

return challenger;

}

return defender;

} );

}

Suggest considering whether it can be integrated into the useFetchBudgetRecommendationEffect hook or extracted as a util to eliminate duplication.

eason9487 · 2024-09-06T06:30:47Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

+		if ( dailyBudget !== undefined ) {
+			// If the amount is already set in session, use that one.
+			const sessionData = clientSession.getCampaign();
+			const { amount: sessionAmount } = sessionData;
+
+			setPaidAds( ( currentPaidAds ) => {
+				currentPaidAds = {
+					...currentPaidAds,
+					amount: sessionAmount || dailyBudget,
+					recommendationData,
+				};
+				return resolveInitialPaidAds( currentPaidAds, targetAudience );
+			} );
+		}


If there is an amount restored from client session, the currentPaidAds.amount is already that value when the first time running this useEffect, so it may not need to read from client session again.

google-listings-and-ads/js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

Lines 112 to 115 in 096c086

// Resolve the starting paid ads data with the campaign data stored in the client session.

const startingPaidAds = {

...defaultPaidAds,

...clientSession.getCampaign(),

Additionally, moving this logic into the resolveInitialPaidAds function would be better as it intends to resolve the initial values.

eason9487 · 2024-09-06T07:05:39Z

tests/e2e/utils/pages/setup-ads/setup-budget.js

+	 * Get budget recommendation tip section.
+	 *
+	 * @return {import('@playwright/test').Locator} The budget recommendation text row.


This JSDoc description is not quite consistent.

eason9487 · 2024-09-10T08:08:52Z

The #2551 seems to have some code conflicts with this PR and even some of the logic might need to be rewritten afterward, so it's recommended to defer adjustment of this PR and rebase this PR onto #2551 after it's approved and merged.

asvinb

@ankitrox I left a comment about setting the initial values. Can you let me know what you think please?
Also there'll be additional work once #2551 is merged.

asvinb · 2024-09-11T14:34:53Z

js/src/components/paid-ads/ads-campaign.js

@@ -55,6 +57,14 @@ export default function AdsCampaign( {
 				'google-listings-and-ads'
 		  );

+	// Set the amount from client session if it is available.
+	useEffect( () => {


@ankitrox Wondering if we can set the amount in the initialValues prop for the forms directly instead of setting the initial form value in the child components?

google-listings-and-ads/js/src/pages/create-paid-ads-campaign/index.js

Line 132 in 24044c5

amount: 0,

google-listings-and-ads/js/src/setup-ads/setup-ads-form.js

Line 32 in 24044c5

amount: 0,

@ankitrox I see AdsCampaign being used in 3 places:

js/src/pages/create-paid-ads-campaign/index.js - the initial values are set via CampaignAssetsForm

js/src/pages/edit-paid-ads-campaign/index.js - the initial values are set via CampaignAssetsForm. Here we don't need to worry about using grabbing amount from localStorage since it's for editing a campaign.

js/src/setup-ads/ads-stepper/index.js - The AdsStepper component is used by SetupAdsForm which also makes use of CampaignAssetsForm to set the initial values.

So that leaves only js/src/pages/create-paid-ads-campaign/index.js and js/src/setup-ads/ads-stepper/index.js where we can potentially set the amount to the value from localStorage. Maybe we can even create a hook for it to reduce the code duplication.

Let me know what you think.

asvinb

@ankitrox I left some more comments. Can you kindly let me know about the suggested approach about setting the default value for amount via the initialValues prop of CampaignAssetsForm.
Also you need to check when there's no recommended budget to not display the recommendation. This is what I can see on my side while testing:

asvinb · 2024-09-12T15:07:15Z

js/src/components/paid-ads/ads-campaign.js

+	);
+
+	const { country = '', daily_budget: dailyBudget } = getHighestBudget(
+		budgetData?.recommendations || []


@ankitrox We already have a check here https://github.com/woocommerce/google-listings-and-ads/pull/2552/files#diff-3bdecec9939ad884905f627b3905c8b138f73d843890bb6d41799694c57f2ab8R10 in case recommendations is falsy. Shall we return an empty array in the getHighestBudget function instead of null?

asvinb · 2024-09-12T15:16:00Z

js/src/components/paid-ads/ads-campaign.js

-			>
-				<CampaignPreviewCard />
-			</BudgetSection>
+			{ ! loading && (


@ankitrox This behaviour is different from what we currently have, i.e having a spinner and loading state while the data is being loaded. Is there a particular reason why we need to wait for the recommendations?

asvinb · 2024-09-12T15:28:10Z

js/src/components/paid-ads/ads-campaign.js

+					formProps={ formContext }
+					disabled={ disabledBudgetSection }
+					countryCodes={ formContext.values.countryCodes }
+					country={ country }


@ankitrox We are passing those new props country, dailyBudget and isMultiple to BudgetSection. However those are being then passed to BudgetRecommendation. Can't we get those values directly in BudgetRecommendation?

asvinb · 2024-09-12T15:28:27Z

js/src/components/paid-ads/ads-campaign.js

+					<CampaignPreviewCard />
+				</BudgetSection>
+			) }
+			{ loading && (


@ankitrox See my comment above.

asvinb · 2024-09-12T15:30:11Z

js/src/components/paid-ads/budget-section/budget-recommendation/index.js

-		return null;
-	}
+	const {
+		isMultiple,


I see the countryCodes prop was removed but it's still being passed to BudgetRecommendation in js/src/components/paid-ads/budget-section/index.js

asvinb · 2024-09-12T15:32:11Z

js/src/components/paid-ads/budget-section/index.js

 * @param {JSX.Element} [props.children] Extra content to be rendered under the card of budget inputs.
 */
 const BudgetSection = ( {
 	formProps,
+	country,


@ankitrox See my previous comment about passing those props.

asvinb · 2024-09-12T15:34:16Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

+	const { country = '', daily_budget: dailyBudget } = getHighestBudget(
+		budgetData?.recommendations || []
+	);
+	const multipleRecommendations = budgetData?.recommendations.length > 1;


@ankitrox The code is duplicated here. Can we move it to a hook which can be reused elsewhere?

ankitrox · 2024-09-16T18:51:30Z

@asvinb I've created the new hook useBudgetRecommendationData, but kept the useEffectin same component because if we move up to SetupAdsForm component as well as for CreatePaidAdsCampaign, it will create the network error issue for useFetchBudgetRecommendationEffect because country codes can be undefined or blank and since these are hooks, we won't be able to call them conditionally.

asvinb

@ankitrox I left some more comments. Can you check them out please?
Most importantly I think we can reduce a lot of the complexity around countryCodes. Right now, we need to fetch the budget recommendation data once the country code changes and the country codes are tied to the form. In #2535 we are planning to remove countryCodes altogether, instead relying on the country codes from useTargetAudienceFinalCountryCodes. Here is what I suggest:

Remove the Audience field everywhere in the current PR (as opposed to removing them in Consolidate the ad creation step in the Ads Setup flow with the one used in Onboarding #2535)
Have the initialValues for CampaignAssetsForm components set with the recommended budget or data from local storage.

The useBudgetRecommendationData won't need to accept any parameters since it can get the list of targeted countries via the useTargetAudienceFinalCountryCodes

What do you think @joemcgill ?

asvinb · 2024-09-17T11:39:11Z

js/src/hooks/useBudgetRecommendationData.js

+	useEffect( () => {
+		if ( ! loading ) {
+			const {
+				country: budgetCountries = '',


@ankitrox This will cause an error in the app when getHighestBudget returns null as you have defined here: https://github.com/woocommerce/google-listings-and-ads/pull/2552/files#diff-3bdecec9939ad884905f627b3905c8b138f73d843890bb6d41799694c57f2ab8R10

asvinb · 2024-09-17T11:41:12Z

js/src/hooks/useBudgetRecommendationData.js

+		useFetchBudgetRecommendationEffect( countryCodes );
+
+	const [ country, setCountry ] = useState( '' );
+	const [ dailyBudget, setDailyBudget ] = useState( 0 );


@ankitrox Instead of defining all those state variables, can we not define only one state variable which is an object having all those properties?

asvinb · 2024-09-17T11:42:01Z

js/src/hooks/useBudgetRecommendationData.js

+
+			setCountry( budgetCountries );
+			setDailyBudget( recommendedDailyBudget );
+			setMultipleRecommendations( data?.recommendations.length > 1 );


@ankitrox Do we need to store that in a state variable? We can have a variable where data?.recommendations.length > 1 and return the variable.

asvinb · 2024-09-17T11:59:30Z

js/src/setup-ads/setup-ads-form.js

 		const args = [ initialValues, values ].map(
 			( { countryCodes, ...v } ) => {
 				v.countrySet = new Set( countryCodes );
 				return v;
 			}
 		);

+		// Set the amount in session storage.
+		if ( isValid && _?.name === 'amount' ) {


@ankitrox Why not use values.amount?

asvinb · 2024-09-17T12:00:21Z

js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-setup-sections.js

 	};

 	return (
 		<Form
 			initialValues={ initialValues }
 			onChange={ ( _, values, isValid ) => {
 				setPaidAds( { ...paidAds, ...values, isValid } );
+
+				if ( isValid ) {
+					clientSession.setCampaign( values );


@ankitrox The campaign is already being updated in local storage here:
https://github.com/woocommerce/google-listings-and-ads/pull/2552/files#diff-6b9f6824ae1208e70b059bf81217131f2d1c42fad1664514c2280500e8e1a7b6R114

Update Budget Setup Card.

a57bf14

github-actions bot added the changelog: update Big changes to something that wasn't broken. label Aug 22, 2024

joemcgill changed the base branch from develop to feature/2459-campaign-creation-flow August 22, 2024 14:29

ankitrox added 2 commits August 22, 2024 20:20

Fix: e2e tests.

273d02b

Add e2e coverage.

9c30663

joemcgill requested changes Aug 26, 2024

View reviewed changes

CR feedback - round 1.

103ae13

joemcgill reviewed Aug 28, 2024

View reviewed changes

Fix: Step change shows no notice.

096c086

joemcgill approved these changes Sep 1, 2024

View reviewed changes

ankitguptaindia self-requested a review September 4, 2024 14:40

ankitguptaindia approved these changes Sep 4, 2024

View reviewed changes

joemcgill requested a review from eason9487 September 4, 2024 15:51

eason9487 requested changes Sep 6, 2024

View reviewed changes

ankitrox added 6 commits September 10, 2024 16:40

Fix: network error for budget recommendation.

76328ea

Remove redundant code.

8d9358d

Update js doc.

ea68ee8

Resolve conflicts and fix tests.

dcc6f73

Fix: lint issues.

ac68177

Remove unused code.

052783e

asvinb requested changes Sep 11, 2024

View reviewed changes

ankitrox added 3 commits September 12, 2024 12:24

Resolve conflict with base branch.

c2fbf1a

use fetch budget hook in paid-ads-setup-sections.

61d73eb

Remove redundant code.

f15bfb9

Display spinner till data gets loaded.

85f5b35

asvinb requested changes Sep 12, 2024

View reviewed changes

ankitrox added 4 commits September 16, 2024 23:52

Add hook for code resuse.

566476d

Use hook.

dc7a4ac

Stick to old UI/UX.

9ddfef4

Remove redundant code.

4af37a3

ankitrox requested a review from asvinb September 16, 2024 18:51

ankitrox added 2 commits September 17, 2024 00:49

Pass recommendations prop.

1b92ecb

Remove redundant code.

ab2db99

asvinb requested changes Sep 17, 2024

View reviewed changes

ankitguptaindia mentioned this pull request Sep 19, 2024

Add minimum budget limit #2583

Open

	/*
	* If a merchant selects more than one country, the budget recommendation
	* takes the highest country out from the selected countries.
	*
	* For example, a merchant selected Brunei (20 USD) and Croatia (15 USD),
	* then the budget recommendation should be (20 USD).
	*/
	function getHighestBudget( recommendations ) {
	return recommendations.reduce( ( defender, challenger ) => {
	if ( challenger.daily_budget > defender.daily_budget ) {
	return challenger;
	}
	return defender;
	} );
	}

	// Resolve the starting paid ads data with the campaign data stored in the client session.
	const startingPaidAds = {
	...defaultPaidAds,
	...clientSession.getCampaign(),

Update Budget Setup Card. #2552

Are you sure you want to change the base?

Update Budget Setup Card. #2552

Conversation

ankitrox commented Aug 22, 2024 • edited by eason9487 Loading

Changes proposed in this Pull Request:

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

codecov bot commented Aug 22, 2024 • edited Loading

Codecov Report

joemcgill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitrox commented Aug 28, 2024

joemcgill left a comment

Choose a reason for hiding this comment

ankitrox commented Aug 30, 2024

joemcgill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitrox commented Sep 2, 2024

ankitguptaindia commented Sep 4, 2024

QA/Test Report- ✅

eason9487 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eason9487 commented Sep 10, 2024

asvinb left a comment

Choose a reason for hiding this comment

asvinb Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asvinb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitrox commented Sep 16, 2024

asvinb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitrox commented Aug 22, 2024 •

edited by eason9487

Loading

codecov bot commented Aug 22, 2024 •

edited

Loading

asvinb Sep 11, 2024 •

edited

Loading