Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Budget Setup Card. #2552

Merged
merged 49 commits into from
Oct 22, 2024

Add missing JSDoc.

a560e90
Select commit
Loading
Failed to load commit list.
Merged

Update Budget Setup Card. #2552

Add missing JSDoc.
a560e90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 0s

62.6% (+0.5%) compared to 425c6e3

View this Pull Request on Codecov

62.6% (+0.5%) compared to 425c6e3

Details

Codecov Report

Attention: Patch coverage is 48.68421% with 39 lines in your changes missing coverage. Please review.

Project coverage is 62.6%. Comparing base (425c6e3) to head (a560e90).

Files with missing lines Patch % Lines
js/src/data/resolvers.js 22.2% 12 Missing and 2 partials ⚠️
js/src/setup-ads/ads-stepper/setup-paid-ads.js 61.5% 10 Missing ⚠️
js/src/utils/getHighestBudget.js 0.0% 5 Missing and 2 partials ⚠️
...-ads/budget-section/budget-recommendation/index.js 0.0% 3 Missing ⚠️
js/src/hooks/useFetchBudgetRecommendation.js 80.0% 2 Missing ⚠️
js/src/pages/create-paid-ads-campaign/index.js 0.0% 1 Missing and 1 partial ⚠️
js/src/components/paid-ads/budget-section/index.js 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2552     +/-   ##
=====================================================================
+ Coverage                                 62.1%   62.6%   +0.5%     
=====================================================================
  Files                                      327     329      +2     
  Lines                                     5109    5166     +57     
  Branches                                  1244    1254     +10     
=====================================================================
+ Hits                                      3171    3232     +61     
+ Misses                                    1756    1752      -4     
  Partials                                   182     182
Files with missing lines Coverage Δ
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/reducer.js 83.8% <100.0%> (+0.3%) ⬆️
js/src/data/selectors.js 50.0% <100.0%> (+1.5%) ⬆️
js/src/data/utils.js 98.0% <100.0%> (+0.1%) ⬆️
js/src/setup-ads/ads-stepper/index.js 100.0% <100.0%> (ø)
js/src/components/paid-ads/budget-section/index.js 15.4% <0.0%> (+4.9%) ⬆️
js/src/hooks/useFetchBudgetRecommendation.js 80.0% <80.0%> (ø)
js/src/pages/create-paid-ads-campaign/index.js 10.0% <0.0%> (-0.3%) ⬇️
...-ads/budget-section/budget-recommendation/index.js 5.3% <0.0%> (+1.3%) ⬆️
js/src/utils/getHighestBudget.js 0.0% <0.0%> (ø)
... and 2 more

... and 5 files with indirect coverage changes

View more details on Codecov