Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Budget Setup Card. #2552
base: feature/2459-campaign-creation-flow
Are you sure you want to change the base?
Update Budget Setup Card. #2552
Changes from 4 commits
a57bf14
273d02b
9c30663
103ae13
096c086
76328ea
8d9358d
ea68ee8
dcc6f73
ac68177
052783e
c2fbf1a
61d73eb
f15bfb9
85f5b35
566476d
dc7a4ac
9ddfef4
4af37a3
1b92ecb
ab2db99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 60 in js/src/components/paid-ads/budget-section/budget-recommendation/index.js
Codecov / codecov/patch
js/src/components/paid-ads/budget-section/budget-recommendation/index.js#L60
Check warning on line 62 in js/src/components/paid-ads/budget-section/budget-recommendation/index.js
Codecov / codecov/patch
js/src/components/paid-ads/budget-section/budget-recommendation/index.js#L62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about in which case it needs this filter?
Check warning on line 33 in js/src/components/paid-ads/budget-section/index.js
Codecov / codecov/patch
js/src/components/paid-ads/budget-section/index.js#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BudgetRecommendation
component doesn't use thecurrency
prop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I understand is that the same logic of setting the default budget will then be applied to all ad creation forms, so moving the
useFetchBudgetRecommendationEffect
hook to the.~/hooks
directory would be more appropriate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is completely the same as:
google-listings-and-ads/js/src/components/paid-ads/budget-section/budget-recommendation/index.js
Lines 15 to 29 in 096c086
Suggest considering whether it can be integrated into the
useFetchBudgetRecommendationEffect
hook or extracted as a util to eliminate duplication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may cause API to fail with a 400 bad request error.
Steps:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
recommendationData
is not used as the form value, so passing it around this way is not ideal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we no longer need to wait for this response after the country setting is changed? It looks like when the country values change, the text that reads "Tip: Most merchants targeting similar countries set a daily budget of %d USD" does change, so we should probably ensure that is still being tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitrox I'm still unsure why we need to remove this. Could you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This JSDoc description is not quite consistent.