Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.4.11 #2010

Merged
merged 79 commits into from
Jul 11, 2023
Merged

release 2.4.11 #2010

merged 79 commits into from
Jul 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 11, 2023

Checklist

  1. Check if the version, base, and target branches are as you desire.
  2. Make sure you have woorelease installed and set up.
  3. Go to your local repo clone, and check out this PR to be able to commit any potential adjustments.
    git fetch origin release/2.4.11
    git checkout release/2.4.11
  4. Remove older changelog entries from readme.txt (keep the last two versions, since we will be adding a third during the release), commit changes.
  5. If there are new database migration classes (under src/DB/Migration/), modify their applicable version set in the get_applicable_version class of each migration class to be the same value as the version that is to be released.
    ⚠️ Notice that x.x.x is not a valid version and should be set manually with the new version. So, for example, if we are releasing version 1.12.0 and there is a file Migration20211228T1640692399.php inside src/DB/Migration/, you should open that file and in the method get_applicable_version return 1.12.0.
  6. ❗ If this release has updated composer packages, we should test Composer package conflicts with other plugins.
  7. Simulate the release locally
    woorelease simulate --product_version=2.4.11  --wc_tested=7.9 --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.4.11
    Note: Select y when prompted: "Would you like to add/delete them in the svn working copy?"
  8. The changelog is correct.
    Check if some entries are missing, need rewording, or need to be deleted. You can edit respective PRs by changing their title, ### Changelog entry section, or assigning the changelog: none label.
    You can also edit the changelog manually in the woorelease release step later.
  9. Automated tests are passing.
  10. Test the package
    1. Install the /tmp/google-listings-and-ads.zip file on a test site
    2. Confirm it activates without warnings/errors and is showing the right versions
    3. Run a few basic smoke tests

Next steps

  1. Do the final release
    woorelease release --product_version=2.4.11  --wc_tested=7.9  --generate_changelog https://github.com/woocommerce/google-listings-and-ads/tree/release/2.4.11
    
    When prompted for changelog entries, double-check and apply any changes if needed.
  2. Go to https://github.com/woocommerce/google-listings-and-ads/releases/2.4.11, generate GitHub release notes, and paste them as a comment here.
  3. Merge this PR after the new release is successfully created and the version tags are updated.
  4. Merge trunk to develop (if applicable for this repo).

tomalec and others added 30 commits June 9, 2023 14:57
to serve a consistent, easy to follow release checklist, and reduce redundancy in wiki pages.

Requires woocommerce/grow#58
…l-tags

Fix the parent options being rendered as the selected tags in the TreeSelectControl
…-attribute-table

Add Empty Data placeholder in Attribute Mapping Table
Add a step to publish the latest extension build for the `develop` branch
Remove an unused hook `useCallbackOnceEffect`
…emove most "Please try again later." from messages in the actions.js
…esult-notification

Avoid continuing to sync settings with GMC after shipping time API failed
eason9487 and others added 20 commits July 4, 2023 16:48
…s called by `CountryCodeTrait`'s callbacks to avoid multiple namespaces.

Address: #2004 (comment)
Add PHP tests for `CountryCodeTrait` and two related API controllers
Add client name and version as request headers
…rror-messages

Adjust the infrastructure to uniform the error messages returned from Google Shopping Content service
@eason9487 eason9487 self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2010 (a716f83) into trunk (2a01b62) will increase coverage by 0.5%.
The diff coverage is 88.2%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             trunk   #2010     +/-   ##
=========================================
+ Coverage     57.5%   58.1%   +0.5%     
- Complexity    4111    4119      +8     
=========================================
  Files          456     455      -1     
  Lines        17655   17688     +33     
=========================================
+ Hits         10158   10271    +113     
+ Misses        7497    7417     -80     
Flag Coverage Δ
php-unit-tests 58.1% <88.2%> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
google-listings-and-ads.php 6.4% <0.0%> (ø)
src/API/Google/AdsAssetGroupAsset.php 84.8% <0.0%> (ø)
src/API/Google/AdsCampaignCriterion.php 100.0% <ø> (ø)
src/API/Google/AdsConversionAction.php 97.6% <ø> (ø)
src/API/Google/Connection.php 1.6% <ø> (ø)
src/API/Google/Middleware.php 85.7% <ø> (ø)
src/MerchantCenter/ContactInformation.php 100.0% <ø> (ø)
src/MerchantCenter/MerchantCenterService.php 93.5% <0.0%> (ø)
src/API/Google/AdsAssetGroup.php 73.7% <66.7%> (ø)
src/API/Google/ExceptionTrait.php 72.7% <84.2%> (ø)
... and 9 more

... and 3 files with indirect coverage changes

@eason9487
Copy link
Member

What's Changed

New Features 🎉

Fixes 🛠

Tweaked 🔧

Developer-facing changes 🧑‍💻

Full Changelog: 2.4.10...2.4.11

@eason9487 eason9487 merged commit 47a2b1c into trunk Jul 11, 2023
@eason9487 eason9487 deleted the release/2.4.11 branch July 11, 2023 03:58
@ianlin ianlin mentioned this pull request Jul 18, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants