-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor product issues #2277
Merged
jorgemd24
merged 20 commits into
feature/refactor-product-stats
from
add/refactor-product-issues
Mar 5, 2024
Merged
Refactor product issues #2277
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b2adf15
Add mc_id to the get_product_view_report response
jorgemd24 afcd5e5
Refactor product issues
jorgemd24 19cf5d0
Adjust merchant center report test
jorgemd24 6466bce
Add delete_stale
jorgemd24 d50f790
Refactor clear cache product statuses
jorgemd24 4634d2f
Add tests to refresh product issues
jorgemd24 d87fb20
Rename function and delete issues if the job fails so we don't have d…
jorgemd24 6a5fcbe
Fix issue with the comparision
jorgemd24 5dea916
Add missing phpdoc
jorgemd24 f4c01b9
Fix phpcs
jorgemd24 f979216
phpcs tests
jorgemd24 5417896
Add @var definition
jorgemd24 6c73cbc
Update PHPDocs
jorgemd24 907bd4a
Update function description
jorgemd24 737351e
Revert delete_stale with compare query
jorgemd24 c75eb4d
Add delete specific product issues
jorgemd24 7f3e1f5
Adjust tests for test_handle_failed_mc_statuses_fetching
jorgemd24 6848100
Add missing return types
jorgemd24 f185a48
Add tests for clear_product_statuses_cache_and_issues
jorgemd24 c06f4e9
Add tests for fetching issues for products with DONT_SYNC_AND_SHOW
jorgemd24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅 We can add
:void
as a return type in the signature to be consistent with the other functions.delete_stale
also missed it, but was not introduced in this PR tho