API PULL - Add a filter for enabling the feature #2340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR enables a filter for enabling the full Notifications feature:
If the
woocommerce_gla_notifications_enabled
is falsewpcom_rest_api_status
will returndisabled
-- Even setting thegla_wpcom_rest_api_status
Option asapproved
,error
ordisapproved
The PR does some naming changes
NotificationsService::is_enabled() -> Just checks the filter.
Options::notifications_enabled() -> Renamed to
Options::is_wpcom_api_authorized()
NotificationsService::is_ready() -> Check if NotificationsService::is_enabled() and if Options::is_wpcom_api_authorized()
Detailed test instructions:
woocommerce_gla_notifications_enabled
is false by default)gla_wpcom_rest_api_status
asapproved
gla_wpcom_rest_api_status
aserror
woocommerce_gla_notifications_enabled
filter as truegla_wpcom_rest_api_status
optiongla_wpcom_rest_api_status
asapproved