Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Connect Test Page errors when WPCOM token is not connected. #2550

Merged

Conversation

jorgemd24
Copy link
Contributor

Changes proposed in this Pull Request:

Part of https://wordpress.org/support/topic/error-on-sync/#post-17964837

When the merchant is on the connection test page and clicks "Get API Pull Integration Status" without having onboarded to the new mechanism, we currently display the following error message:

image

This can be confusing, as mentioned in the forum ticket. To address this, this PR removes the error if the "Google Token Health" is disconnected, as it already indicated that there is no token.

Screenshots:

Detailed test instructions:

  1. Make sure that you haven’t onboarded to the new sync mechanism.
  2. Go to the Connect Test Page: /wp-admin/admin.php?page=connection-test-admin-page
  3. Click "Get API Pull Integration Status"
  4. See that the "Google Token Health" already indicates that there is no token associated and no errors are shown.

Additional details:

Changelog entry

Tweak - Connect Test Page errors when WPCOM token is not connected.

@jorgemd24 jorgemd24 self-assigned this Aug 20, 2024
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.0%. Comparing base (94e9f2f) to head (cc5adf7).
Report is 12 commits behind head on develop.

Files Patch % Lines
src/ConnectionTest.php 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2550      +/-   ##
============================================
+ Coverage       63.8%   65.0%    +1.2%     
- Complexity         0    4588    +4588     
============================================
  Files            326     475     +149     
  Lines           5089   17900   +12811     
  Branches        1232       0    -1232     
============================================
+ Hits            3247   11640    +8393     
- Misses          1674    6260    +4586     
+ Partials         168       0     -168     
Flag Coverage Δ
js-unit-tests ?
php-unit-tests 65.0% <0.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ConnectionTest.php 0.0% <0.0%> (ø)

... and 800 files with indirect coverage changes

@jorgemd24 jorgemd24 marked this pull request as ready for review August 20, 2024 16:20
@eason9487 eason9487 requested a review from a team August 21, 2024 02:12
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jorgemd24, thanks for making the connection test easier to understand.

On a new site that hasn't onboarded with the new API Pull I see that the Google token health is Disconnected and no errors are listed:

Screenshot 2024-08-21 at 10 32 02

@jorgemd24 jorgemd24 merged commit 315fce2 into develop Aug 21, 2024
14 checks passed
@jorgemd24 jorgemd24 deleted the tweak/handle-no-wpcom-token-when-getting-api-pull-status branch August 21, 2024 17:24
@tomalec tomalec mentioned this pull request Aug 27, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants