Consolidate Ad Creation

[asvinb]

Changes proposed in this Pull Request:

Closes #2535

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

[codecov]

Codecov Report

Attention: Patch coverage is 2.81690% with 69 lines in your changes missing coverage. Please review.

Project coverage is 62.4%. Comparing base (315fce2) to head (8e95434).

Files with missing lines	Patch %	Lines
js/src/components/paid-ads/ads-campaign/index.js	0.0%	39 Missing and 5 partials ⚠️
...rc/components/paid-ads/ads-campaign/skip-button.js	0.0%	9 Missing and 2 partials ⚠️
...s/paid-ads/ads-campaign/paid-ads-setup-sections.js	0.0%	6 Missing and 2 partials ⚠️
...paid-ads/ads-campaign/paid-ads-features-section.js	0.0%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@                            Coverage Diff                            @@
##             feature/2460-simplify-paid-ads-setup   #2575      +/-   ##
=========================================================================
- Coverage                                    65.0%   62.4%    -2.7%     
=========================================================================
  Files                                         475     334     -141     
  Lines                                       17900    5226   -12674     
  Branches                                        0    1269    +1269     
=========================================================================
- Hits                                        11640    3259    -8381     
+ Misses                                       6260    1781    -4479     
- Partials                                        0     186     +186     

Flag	Coverage Δ
js-unit-tests	62.4% <2.8%> (?)
php-unit-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../components/paid-ads/ads-campaign/clientSession.js	25.0% <ø> (ø)
.../src/components/paid-ads/ads-campaign/constants.js	100.0% <100.0%> (ø)
js/src/pages/create-paid-ads-campaign/index.js	10.8% <ø> (ø)
js/src/pages/edit-paid-ads-campaign/index.js	9.4% <ø> (ø)
js/src/setup-ads/ads-stepper/index.js	100.0% <ø> (ø)
.../src/setup-mc/setup-stepper/saved-setup-stepper.js	87.8% <ø> (ø)
...paid-ads/ads-campaign/paid-ads-features-section.js	0.0% <0.0%> (ø)
...s/paid-ads/ads-campaign/paid-ads-setup-sections.js	2.1% <0.0%> (ø)
...rc/components/paid-ads/ads-campaign/skip-button.js	0.0% <0.0%> (ø)
js/src/components/paid-ads/ads-campaign/index.js	0.0% <0.0%> (ø)

... and 799 files with indirect coverage changes

[joemcgill]

@asvinb wanted to leave an early review with some observations I'm seeing. I can see that you have copied the onboarding flow's component, SetupPaidAds, to a new AdsCampaign component, which makes sense to me. However, in doing so, it doesn't include the changes made to that form related to #2459. I worry that this is going to lead to some challenging merge conflict resolution. Is it possible to try merging the feature/2459-campaign-creation-flow branch into this branch and ensure those changes are all included?

Additionally, to try to reduce some of the complexity juggling work in parallel with tickets like this one, #2502, and #2503, we should merge all of the PRs targeted to feature/2460-simplify-paid-ads-setup to the feature branch for #2459 and make them one feature rather than two.

[joemcgill]

The changes to the AdsCampaign component in #2531 need to be preserved here.

[joemcgill]

The shouldShowPaidAdsSetup logic was removed in #2533. Is there a reason it needs to be added back here?

[asvinb]

@joemcgill The PR is no longer relevant unfortunately. I'll close it in favour of #2623